You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:04:33 UTC
[GitHub] [lucene-solr] iverase opened a new pull request #1558: LUCENE-9398: BKD tree is now read always off-heap
iverase opened a new pull request #1558:
URL: https://github.com/apache/lucene-solr/pull/1558
This change makes the BKD index to be read always off-heap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] iverase commented on pull request #1558: LUCENE-9398: BKD tree is now read always off-heap
Posted by GitBox <gi...@apache.org>.
iverase commented on pull request #1558:
URL: https://github.com/apache/lucene-solr/pull/1558#issuecomment-641353631
I went a bit wild! I revert that commit and just remove accountable from the BKD reader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] iverase merged pull request #1558: LUCENE-9398: BKD tree is now read always off-heap
Posted by GitBox <gi...@apache.org>.
iverase merged pull request #1558:
URL: https://github.com/apache/lucene-solr/pull/1558
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz commented on pull request #1558: LUCENE-9398: BKD tree is now read always off-heap
Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #1558:
URL: https://github.com/apache/lucene-solr/pull/1558#issuecomment-641300726
I was thinking of a middle ground where PointsReader still implements Accountable (I'm planning to remove as part of [LUCENE-9387](https://issues.apache.org/jira/browse/LUCENE-9387)) but our implementations always return 0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz commented on a change in pull request #1558: LUCENE-9398: BKD tree is now read always off-heap
Posted by GitBox <gi...@apache.org>.
jpountz commented on a change in pull request #1558:
URL: https://github.com/apache/lucene-solr/pull/1558#discussion_r437354349
##########
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDReader.java
##########
@@ -871,7 +746,7 @@ private long estimatePointCount(IntersectState state, byte[] cellMinPacked, byte
@Override
public long ramBytesUsed() {
- return packedIndex.ramBytesUsed();
+ return 0;
}
Review comment:
Let's remove Accountable from BKDReader instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org