You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/04/14 09:23:56 UTC
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18418
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
This issue is related to IMPALA-11187, 'test_read_mode' can have
unpredicted results by its nature, it sets the 'kudu_read_mode' to
'READ_LATEST'. The 'test_replica_selection' runs just after
'test_read_mode' and the Kudu tests use the same Impala client, thus
'kudu_read_mode=READ_LATEST' persists.
This commit set 'kudu_read_mode=READ_AT_SNAPSHOT' for
'test_replica_selection'.
Testing:
- Ran 'test_replica_selection'
Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
---
M tests/query_test/test_kudu.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/18418/1
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 17:03:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
This issue is related to IMPALA-11187, 'test_read_mode' can have
unpredicted results by its nature, it sets the 'kudu_read_mode' to
'READ_LATEST'. The 'test_replica_selection' runs just after
'test_read_mode' and the Kudu tests use the same Impala client, thus
'kudu_read_mode=READ_LATEST' persists.
This commit set 'kudu_read_mode=READ_AT_SNAPSHOT' for
'test_replica_selection'.
Testing:
- Ran 'test_replica_selection'
Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Reviewed-on: http://gerrit.cloudera.org:8080/18418
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_kudu.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8055/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 16:47:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8049/
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 21:32:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 2:
Hit flaky test IMPALA-7864
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 16:46:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 21:09:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 1: Code-Review+2
Thanks for working on this.
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 17:02:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8049/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 17:03:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 2:
Just started a dry_run, these tests are successful locally, maybe there is a deeper problem with the kudu tests.
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 08:41:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 2:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8054/
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 13:02:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10450/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 09:45:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8054/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 08:39:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10733: Fix flaky TestKuduOperations.test replica selection
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18418 )
Change subject: IMPALA-10733: Fix flaky TestKuduOperations.test_replica_selection
......................................................................
Patch Set 3:
Thank you for the review and catching the related issue Wenzhe.
--
To view, visit http://gerrit.cloudera.org:8080/18418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98edf6af8ac67bab65d1c09d3e3b6f9343da854
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Apr 2022 07:07:49 +0000
Gerrit-HasComments: No