You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Bill Ricky <mh...@gmail.com> on 2020/07/15 16:53:05 UTC
Re: Review Request 72645: RANGER-2895: Replace c3p0 connection pool
with HikariCP, upgrading MySQL connector
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72645/
-----------------------------------------------------------
(Updated 七月 15, 2020, 4:53 p.m.)
Review request for ranger.
Summary (updated)
-----------------
RANGER-2895: Replace c3p0 connection pool with HikariCP, upgrading MySQL connector
Bugs: RANGER-2895
https://issues.apache.org/jira/browse/RANGER-2895
Repository: ranger
Description (updated)
-------
We should replace c3p0 with [HikariCP|https://github.com/brettwooldridge/HikariCP]. HikariCP is much faster and less error prone. HikariCP is more popular with 13.2k+ stars on its github. There were no more new commits since Nov 18, 2019 in [c3p0|https://github.com/swaldman/c3p0/commits/master].
[MySQL connector|https://github.com/mysql/mysql-connector-j] should be upgraded to the latest stable versions as well to include many essential bugfixes.
Diffs
-----
pom.xml 5bfd08df2
security-admin/pom.xml 745dbfe8c
security-admin/scripts/ranger-admin-site-template.xml 72ff66eaf
security-admin/scripts/setup.sh 949c24244
security-admin/scripts/upgrade_admin.py 10fa485bd
security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml fcd4bd0ee
security-admin/src/main/webapp/META-INF/applicationContext.xml b24f4d4ac
Diff: https://reviews.apache.org/r/72645/diff/2/
Testing
-------
1.Compilation OK
2.Already used in production environment
File Attachments
----------------
0001-RANGER-2895-Replace-c3p0-connection-pool-with-Hikari.patch
https://reviews.apache.org/media/uploaded/files/2020/07/15/b97f3da3-094a-45f0-a311-0eddd7b2ee71__0001-RANGER-2895-Replace-c3p0-connection-pool-with-Hikari.patch
Thanks,
Bill Ricky