You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/11/10 14:24:44 UTC
[GitHub] [hadoop] hadoop-yetus commented on pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces
hadoop-yetus commented on PR #5123:
URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1310359431
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 56s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | buf | 0m 0s | | buf was not available. |
| +0 :ok: | buf | 0m 0s | | buf was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 15m 8s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 28m 25s | | trunk passed |
| +1 :green_heart: | compile | 7m 0s | | trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 6m 25s | | trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 29s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 57s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 44s | | trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 1m 48s | | trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 4m 23s | | trunk passed |
| +1 :green_heart: | shadedclient | 23m 45s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 29s | | the patch passed |
| +1 :green_heart: | compile | 6m 35s | | the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | cc | 6m 35s | | the patch passed |
| -1 :x: | javac | 6m 35s | [/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/1/artifact/out/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt) | hadoop-hdfs-project-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 1 new + 1133 unchanged - 1 fixed = 1134 total (was 1134) |
| +1 :green_heart: | compile | 6m 19s | | the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | cc | 6m 19s | | the patch passed |
| -1 :x: | javac | 6m 19s | [/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/1/artifact/out/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt) | hadoop-hdfs-project-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 1 new + 1102 unchanged - 1 fixed = 1103 total (was 1103) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 1m 16s | [/results-checkstyle-hadoop-hdfs-project.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/1/artifact/out/results-checkstyle-hadoop-hdfs-project.txt) | hadoop-hdfs-project: The patch generated 1 new + 1 unchanged - 1 fixed = 2 total (was 2) |
| +1 :green_heart: | mvnsite | 1m 36s | | the patch passed |
| -1 :x: | javadoc | 0m 32s | [/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/1/artifact/out/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt) | hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 99 new + 0 unchanged - 99 fixed = 99 total (was 99) |
| +1 :green_heart: | javadoc | 1m 32s | | the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| -1 :x: | spotbugs | 3m 4s | [/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/1/artifact/out/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.html) | hadoop-hdfs-project/hadoop-hdfs-client generated 39 new + 0 unchanged - 0 fixed = 39 total (was 0) |
| +1 :green_heart: | shadedclient | 24m 21s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 34s | | hadoop-hdfs-client in the patch passed. |
| -1 :x: | unit | 40m 19s | [/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt) | hadoop-hdfs-rbf in the patch passed. |
| +1 :green_heart: | asflicense | 0m 43s | | The patch does not generate ASF License warnings. |
| | | 188m 14s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hadoop-hdfs-project/hadoop-hdfs-client |
| | org.apache.hadoop.hdfs.ClientGSIContext.mergeRouterFederatedState(ByteString) makes inefficient use of keySet iterator instead of entrySet iterator At ClientGSIContext.java:keySet iterator instead of entrySet iterator At ClientGSIContext.java:[line 104] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$AddMountTableEntryResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 15550] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$DisableNameserviceRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 32175] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$DisableNameserviceResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 32725] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$DisabledNameserviceRecordProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 31511] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$EnableNameserviceRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 33261] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$EnableNameserviceResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 33811] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$EnterSafeModeRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 28594] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$EnterSafeModeResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 29053] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$FederationNamespaceInfoProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 5776] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetDestinationRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 19767] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetDestinationResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 20348] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetDisabledNameservicesRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 34267] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetDisabledNameservicesResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 34757] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetExpiredRegistrationsRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 7849] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetMountTableEntriesRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 18303] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetNamespaceInfoRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 8260] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetRouterRegistrationRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 23244] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetRouterRegistrationsRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 24362] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetSafeModeRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 30424] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetSafeModeResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 30883] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$LeaveSafeModeRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 29509] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$LeaveSafeModeResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 29968] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$NamenodeHeartbeatResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 11532] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$NamenodeMembershipStatsRecordProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 1362] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RefreshMountTableEntriesRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 26764] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RefreshMountTableEntriesResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 27223] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RefreshSuperUserGroupsConfigurationRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 27679] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RefreshSuperUserGroupsConfigurationResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 28138] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RemoteLocationProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 12146] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RemoveMountTableEntryRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 17217] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RemoveMountTableEntryResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 17767] |
| | Class org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RouterFederatedStateProto defines non-transient non-serializable instance field namespaceStateIds_ In HdfsServerFederationProtos.java:instance field namespaceStateIds_ In HdfsServerFederationProtos.java |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RouterFederatedStateProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 35510] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RouterHeartbeatResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 26308] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$StateStoreVersionRecordProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 20965] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$UpdateMountTableEntryResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 16681] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$UpdateNamenodeRegistrationRequestProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 9688] |
| | Useless control flow in org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$UpdateNamenodeRegistrationResponseProto$Builder.maybeForceBuilderInitialization() At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 10412] |
| Failed junit tests | hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver |
| | hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/5123 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat |
| uname | Linux 507f8fbb119a 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 8fda01d89a22e42b1eb90d742062baa60b7d9a53 |
| Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/1/testReport/ |
| Max. process+thread count | 2380 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5123/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org