[GitHub] [cassandra] JeetKunDoug commented on a diff in pull request #2318: CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework

["JeetKunDoug (via GitHub)" <gi...@apache.org>]

JeetKunDoug commented on code in PR #2318:
URL: https://github.com/apache/cassandra/pull/2318#discussion_r1191223246


##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -219,6 +219,8 @@
 
     /** This property indicates whether disable_mbean_registration is true */
     IS_DISABLED_MBEAN_REGISTRATION("org.apache.cassandra.disable_mbean_registration"),
+    /** This property indicates if the code is running under the in-jvm dtest framework */

Review Comment:
   Thankfully no - this enum is really just a convenience wrapper around system properties, so the ordering doesn't matter (and other folks seem to add things where they make sense vs. at the end as well).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org