You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/01/14 00:12:22 UTC
Review Request 42275: Added utility functions to create docker URI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42275/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296
Repository: mesos
Description
-------
Added utility functions to create docker URI.
See the usage in subsequent patches.
Diffs
-----
src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
src/uri/schemes/docker.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/42275/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 42275: Added utility functions to create docker
URI.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42275/
-----------------------------------------------------------
(Updated Jan. 17, 2016, 9:51 p.m.)
Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
Changes
-------
Rebased.
Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296
Repository: mesos
Description (updated)
-------
Added utility functions to create docker URI.
Diffs (updated)
-----
src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1
src/uri/schemes/docker.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/42275/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 42275: Added utility functions to create docker
URI.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42275/#review114767
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2016, 11:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42275/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:12 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added utility functions to create docker URI.
>
> See the usage in subsequent patches.
>
>
> Diffs
> -----
>
> src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
> src/uri/schemes/docker.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42275/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42275: Added utility functions to create docker
URI.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42275/#review114753
-----------------------------------------------------------
Ship it!
Do we need some comments on we are mapping `tag` to `query`?
- Gilbert Song
On Jan. 13, 2016, 3:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42275/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 3:12 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added utility functions to create docker URI.
>
> See the usage in subsequent patches.
>
>
> Diffs
> -----
>
> src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
> src/uri/schemes/docker.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42275/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>