You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/01/24 18:21:44 UTC

Review Request 55887: Check task user before allowing a task to be launched on the agent.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55887/
-----------------------------------------------------------

Review request for mesos, Adam B and Jiang Yan Xu.


Bugs: MESOS-6953
    https://issues.apache.org/jira/browse/MESOS-6953


Repository: mesos


Description
-------

Added support for action `run_tasks` on the agent's flag `acl`. Based on
the ACL configured for `run_tasks`, a task to be launched on the agent
will be (dis)allowed to launch on the agent.
If a task or task group cannot be launched due to failed authorization,
a `TASK_FAILED` Status Update shall be sent with a reason code of
`REASON_TASK_UNAUTHORIZED` or `REASON_TASK_GROUP_UNAUTHORIZED` as
applicable.
Note that in case of a task group, all tasks fail if any of the tasks
within the task group encounter the authorization error.


Diffs
-----

  src/slave/slave.hpp 0dadbe50be15f89b791da55fa10f1b434693ee0f 
  src/slave/slave.cpp 0548b04073c0ba4adfc4433d75fd18c2ba79d891 

Diff: https://reviews.apache.org/r/55887/diff/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha