You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philippe M. Chiasson" <go...@ectoplasm.org> on 2008/02/03 09:02:15 UTC

[mp2 patch] Support for ithreads in Perl 5.10

I am going to post a more detailled explanation of the following patch
in a little bit, but it takes care of one more *big* bug that would basically
segfault against threads Perl as soon as perl-level threads were spawned.
Not good.

The patches fixes that part for me, and the test suite is looking much
happier by now. Before I check this in, I need to clean things up a little
more and I am worried this could introduce the usual Win32 breakeage and
possibly against Perl 5.6, all and any testing certainly welcome from the
folks already jumping to 5.10

Failed Test                  Stat Wstat Total Fail  List of Failed
-------------------------------------------------------------------------------
t/directive/perlloadmodule.t  255 65280    ??   ??  ??
t/directive/perlrequire.t                   2    1  1
t/perl/ithreads2.t            255 65280    ??   ??  ??
6 tests and 17 subtests skipped.
Failed 3/244 test scripts. 1/2631 subtests failed.
Files=244, Tests=2631, 208 wallclock secs (142.38 cusr + 18.50 csys = 160.88 CPU)

Not quite "works with Perl 5.10" yet, but getting there.

-- 
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/

Re: [mp2 patch] Support for ithreads in Perl 5.10

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Sun, 3 Feb 2008, Philippe M. Chiasson wrote:

> Randy Kobes wrote:
>> 
>> All tests succeed on Win32 - perl-5.10.0 (ActivePerl build
>> 1002) with Apache/2.2.8.
>
> Cool, in light of this, I am tempted to quickly get this last patch in,
> and head for a release shortly after.
>
> Before I go into RC mode, is here any other outstanding bugs/patches
> you think I should have a look at?

Not that I'm aware of ...

> The idea would be to quickly get something out there that works just fine
> with 5.10, then get back to life as usual.

+1

-- 
best regards,
Randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2 patch] Support for ithreads in Perl 5.10

Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Randy Kobes wrote:
> On Sun, 3 Feb 2008, Philippe M. Chiasson wrote:
> 
>> Scratch that last comment! A slightly tweaked patch is attached.
>>
>> All tests successful, 5 tests and 17 subtests skipped.
>> Files=244, Tests=2651, 149 wallclock secs (77.19 cusr + 15.58 csys = 92.77 
>> CPU)
> 
> gozer++!
> 
> All tests succeed on Win32 - perl-5.10.0 (ActivePerl build
> 1002) with Apache/2.2.8.

Cool, in light of this, I am tempted to quickly get this last patch in,
and head for a release shortly after.

Before I go into RC mode, is here any other outstanding bugs/patches
you think I should have a look at?

The idea would be to quickly get something out there that works just fine
with 5.10, then get back to life as usual.

-- 
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/


Re: [mp2 patch] Support for ithreads in Perl 5.10

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Sun, 3 Feb 2008, Philippe M. Chiasson wrote:

> Scratch that last comment! A slightly tweaked patch is attached.
>
> All tests successful, 5 tests and 17 subtests skipped.
> Files=244, Tests=2651, 149 wallclock secs (77.19 cusr + 15.58 csys = 92.77 
> CPU)

gozer++!

All tests succeed on Win32 - perl-5.10.0 (ActivePerl build
1002) with Apache/2.2.8.

-- 
best regards,
Randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2 patch] Support for ithreads in Perl 5.10

Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Philippe M. Chiasson wrote:
> I am going to post a more detailled explanation of the following patch
> in a little bit, but it takes care of one more *big* bug that would basically
> segfault against threads Perl as soon as perl-level threads were spawned.
> Not good.
> 
> The patches fixes that part for me, and the test suite is looking much
> happier by now. Before I check this in, I need to clean things up a little
> more and I am worried this could introduce the usual Win32 breakeage and
> possibly against Perl 5.6, all and any testing certainly welcome from the
> folks already jumping to 5.10
> 
> Failed Test                  Stat Wstat Total Fail  List of Failed
> -------------------------------------------------------------------------------
> t/directive/perlloadmodule.t  255 65280    ??   ??  ??
> t/directive/perlrequire.t                   2    1  1
> t/perl/ithreads2.t            255 65280    ??   ??  ??
> 6 tests and 17 subtests skipped.
> Failed 3/244 test scripts. 1/2631 subtests failed.
> Files=244, Tests=2631, 208 wallclock secs (142.38 cusr + 18.50 csys = 160.88 CPU)
> 
> Not quite "works with Perl 5.10" yet, but getting there.

Scratch that last comment! A slightly tweaked patch is attached.

All tests successful, 5 tests and 17 subtests skipped.
Files=244, Tests=2651, 149 wallclock secs (77.19 cusr + 15.58 csys = 92.77 CPU)

Turns out the errors I am seeing are because I've been testing against
a debugging build of perl that turns on all sorts of extra sanity checks,
and we are failing in there.

It does point to things that needs fixing anyhow, but once this patch
is tested not to break anything, I'd be tempted to claim "Works with Perl-5.10"

So, if you could please give this patch a spin to see what it breaks,
if anything.

Thanks!

-- 
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/