You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/26 14:30:48 UTC
[GitHub] [superset] EugeneTorap opened a new pull request, #22230: chore: Move charts to src/pages folder
EugeneTorap opened a new pull request, #22230:
URL: https://github.com/apache/superset/pull/22230
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Moved ChartCreation & ChartList to `src/pages` folder to apply direction outlined in #13632
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #22230:
URL: https://github.com/apache/superset/pull/22230#issuecomment-1337161954
I think it looks good, but pinging @michael-s-molina for review as his more familiar with the proposed folder structure.
1 concern though - if we're moving stuff to the new `/pages` folder, shouldn't we move all pages at once, so that there's no inconsistency before the rest of the pages are moved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #22230:
URL: https://github.com/apache/superset/pull/22230#issuecomment-1337358976
> @michael-s-molina Deal me in!
Cool. I'll wait for the discussion before merging this PR then. Feel free to ping me when the discussion is open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22230:
URL: https://github.com/apache/superset/pull/22230#issuecomment-1380972678
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #22230:
URL: https://github.com/apache/superset/pull/22230#issuecomment-1380949420
@michael-s-molina Can we merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #22230:
URL: https://github.com/apache/superset/pull/22230#issuecomment-1380950057
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #22230:
URL: https://github.com/apache/superset/pull/22230#issuecomment-1337323306
> @kgabryje If we move all pages at once we break a lot of open PR. I guess the best strategy would be to move them one by one and select only those pages that have little activity so as not to break current PRs.
I agree. I'm taking the iterative approach to reduce impact.
@EugeneTorap One thing I was planning to do before start moving components to the pages folder was to create a sketch of how it would look in the end. This would help with folder naming definitions, how to break the work into multiple PRs, and with the reviews. This is also a required step for the final wiki page that will contain the final proposed structure. The idea would be to do a before/after of the components involved with the pages so we can validate the structure. Something like:
Before
```
src
addSlice
views
CRUD
chart
```
After
```
src/pages
charts
chartCreation
chartList
```
I think the best place for this work is a Github discussion with the title `SIP-61 src/pages structure proposal`. Given that you're interested in the project, would you like to draw this sketch and open the discussion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #22230:
URL: https://github.com/apache/superset/pull/22230#issuecomment-1337170839
@kgabryje If we move all pages at once we break a lot of open PR. I guess the best strategy would be to move them one by one and select only those pages that have little activity so as not to break current PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #22230:
URL: https://github.com/apache/superset/pull/22230#issuecomment-1337987539
@michael-s-molina Done! #22330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged PR #22230:
URL: https://github.com/apache/superset/pull/22230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22230:
URL: https://github.com/apache/superset/pull/22230#issuecomment-1380952461
@michael-s-molina Ephemeral environment spinning up at http://35.91.199.214:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22230:
URL: https://github.com/apache/superset/pull/22230#issuecomment-1328064988
# [Codecov](https://codecov.io/gh/apache/superset/pull/22230?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22230](https://codecov.io/gh/apache/superset/pull/22230?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f05b6de) into [master](https://codecov.io/gh/apache/superset/commit/a8bc53d805b404adf395cf7a844402fffd6fe220?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8bc53d) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #22230 +/- ##
==========================================
- Coverage 66.86% 66.84% -0.02%
==========================================
Files 1840 1841 +1
Lines 70161 70187 +26
Branches 7657 7662 +5
==========================================
+ Hits 46910 46918 +8
- Misses 21281 21295 +14
- Partials 1970 1974 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.67% <100.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...es/charts/chartCreation/ChartCreationContainer.tsx](https://codecov.io/gh/apache/superset/pull/22230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL2NoYXJ0cy9jaGFydENyZWF0aW9uL0NoYXJ0Q3JlYXRpb25Db250YWluZXIudHN4) | `59.61% <ø> (ø)` | |
| [...-frontend/src/pages/charts/chartList/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/22230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL2NoYXJ0cy9jaGFydExpc3QvQ2hhcnRDYXJkLnRzeA==) | `52.17% <ø> (ø)` | |
| [...-frontend/src/pages/charts/chartList/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/22230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL2NoYXJ0cy9jaGFydExpc3QvQ2hhcnRMaXN0LnRzeA==) | `55.03% <ø> (ø)` | |
| [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/22230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `62.00% <ø> (ø)` | |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/22230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `55.26% <100.00%> (ø)` | |
| [...t-frontend/src/dashboard/util/getOverwriteItems.ts](https://codecov.io/gh/apache/superset/pull/22230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldE92ZXJ3cml0ZUl0ZW1zLnRz) | `90.90% <0.00%> (ø)` | |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/22230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <0.00%> (ø)` | |
| [.../plugin-chart-echarts/src/Timeseries/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/22230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9idWlsZFF1ZXJ5LnRz) | `71.42% <0.00%> (ø)` | |
| [...superset-ui-core/src/query/types/PostProcessing.ts](https://codecov.io/gh/apache/superset/pull/22230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvdHlwZXMvUG9zdFByb2Nlc3NpbmcudHM=) | `100.00% <0.00%> (ø)` | |
| [...et-ui-chart-controls/src/operators/sortOperator.ts](https://codecov.io/gh/apache/superset/pull/22230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL29wZXJhdG9ycy9zb3J0T3BlcmF0b3IudHM=) | `100.00% <0.00%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/superset/pull/22230/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #22230: chore: Move charts to src/pages folder
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #22230:
URL: https://github.com/apache/superset/pull/22230#issuecomment-1337350000
@michael-s-molina Deal me in!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org