You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2026/04/21 10:43:30 UTC

[Impala-ASF-CR] IMPALA-14774: Increase sync hms events wait time s to avoid HMS event sync timeout

k.venureddy2103@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24216


Change subject: IMPALA-14774: Increase sync_hms_events_wait_time_s to avoid HMS event sync timeout
......................................................................

IMPALA-14774: Increase sync_hms_events_wait_time_s to avoid HMS event sync timeout

metadata/test_ddl.py::TestDdlStatements::test_truncate_table and
metadata/test_event_processing.py::TestEventSyncWaiting::test_txn
running concurrently on the same cluster has caused the issue.

TRUNCATE_TABLE with 24 partitions held the table write lock
for about 13 seconds. Event processing thread waited to acquire
the lock for test_truncate_table test.
Another thread waited for the HMS event sync to finish
(sync_hms_events_wait_time_s=10sec) till the latest event ID
for test_txn test. Since the truncate took over 10 seconds,
HMS event sync timedout and failed test.
This issue doesn't happen after IMPALA-14535 because HMS event
sync is optimised to wait for table level granularity instead
of waiting for global latest event id.

This patch increases the timeout value to reduce the chance
of failure even if some builds do not have IMPALA-14535 fix.

Testing:
- Executed existing tests.

Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
---
M tests/metadata/test_event_processing.py
M tests/metadata/test_event_processing_base.py
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/24216/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
Gerrit-Change-Number: 24216
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <k....@gmail.com>

[Impala-ASF-CR] IMPALA-14774: Increase sync hms events wait time s to avoid HMS event sync timeout

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24216 )

Change subject: IMPALA-14774: Increase sync_hms_events_wait_time_s to avoid HMS event sync timeout
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22188/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
Gerrit-Change-Number: 24216
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 10:56:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14774: Increase HMS event sync wait time to avoid timeout

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24216 )

Change subject: IMPALA-14774: Increase HMS event sync wait time to avoid timeout
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
Gerrit-Change-Number: 24216
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 16:50:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14774: Increase sync hms events wait time s to avoid HMS event sync timeout

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24216 )

Change subject: IMPALA-14774: Increase sync_hms_events_wait_time_s to avoid HMS event sync timeout
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
Gerrit-Change-Number: 24216
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 15:40:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14774: Increase HMS event sync wait time to avoid timeout

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Sai Hemanth Gantasala, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24216

to look at the new patch set (#2).

Change subject: IMPALA-14774: Increase HMS event sync wait time to avoid timeout
......................................................................

IMPALA-14774: Increase HMS event sync wait time to avoid timeout

metadata/test_ddl.py::TestDdlStatements::test_truncate_table and
metadata/test_event_processing.py::TestEventSyncWaiting::test_txn
running concurrently on the same cluster has caused the issue.

TRUNCATE_TABLE with 24 partitions held the table write lock
for about 13 seconds. Event processing thread waited to acquire
the lock for test_truncate_table test.
Another thread waited for the HMS event sync to finish
(sync_hms_events_wait_time_s=10sec) till the latest event ID
for test_txn test. Since the truncate took over 10 seconds,
HMS event sync timed out and failed test.
This issue doesn't happen after IMPALA-14535 because HMS event
sync is optimised to wait for table level granularity instead
of waiting for global latest event id.

This change reduces the chance of such failure and is easy to
backport, even though the issue didn't occur since IMPALA-14535.

Testing:
- Executed existing tests.

Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
---
M tests/metadata/test_event_processing.py
M tests/metadata/test_event_processing_base.py
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/24216/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
Gerrit-Change-Number: 24216
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-14774: Increase HMS event sync wait time to avoid timeout

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24216 )

Change subject: IMPALA-14774: Increase HMS event sync wait time to avoid timeout
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
Gerrit-Change-Number: 24216
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 12:14:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14774: Increase sync hms events wait time s to avoid HMS event sync timeout

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24216 )

Change subject: IMPALA-14774: Increase sync_hms_events_wait_time_s to avoid HMS event sync timeout
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13356/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
Gerrit-Change-Number: 24216
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 11:16:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14774: Increase sync hms events wait time s to avoid HMS event sync timeout

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24216 )

Change subject: IMPALA-14774: Increase sync_hms_events_wait_time_s to avoid HMS event sync timeout
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24216/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24216/1//COMMIT_MSG@19
PS1, Line 19: timedout
nit: timed out


http://gerrit.cloudera.org:8080/#/c/24216/1//COMMIT_MSG@25
PS1, Line 25:  even if some builds do not have IMPALA-14535 fix.
I would rephrase this - this change reduces the chance of such failure and is easy to backport, even though the issue didn't occur since IMPALA-14535



-- 
To view, visit http://gerrit.cloudera.org:8080/24216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
Gerrit-Change-Number: 24216
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 11:17:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14774: Increase HMS event sync wait time to avoid timeout

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24216 )

Change subject: IMPALA-14774: Increase HMS event sync wait time to avoid timeout
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13363/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
Gerrit-Change-Number: 24216
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 12:21:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14774: Increase HMS event sync wait time to avoid timeout

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24216 )

Change subject: IMPALA-14774: Increase HMS event sync wait time to avoid timeout
......................................................................

IMPALA-14774: Increase HMS event sync wait time to avoid timeout

metadata/test_ddl.py::TestDdlStatements::test_truncate_table and
metadata/test_event_processing.py::TestEventSyncWaiting::test_txn
running concurrently on the same cluster has caused the issue.

TRUNCATE_TABLE with 24 partitions held the table write lock
for about 13 seconds. Event processing thread waited to acquire
the lock for test_truncate_table test.
Another thread waited for the HMS event sync to finish
(sync_hms_events_wait_time_s=10sec) till the latest event ID
for test_txn test. Since the truncate took over 10 seconds,
HMS event sync timed out and failed test.
This issue doesn't happen after IMPALA-14535 because HMS event
sync is optimised to wait for table level granularity instead
of waiting for global latest event id.

This change reduces the chance of such failure and is easy to
backport, even though the issue didn't occur since IMPALA-14535.

Testing:
- Executed existing tests.

Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
Reviewed-on: http://gerrit.cloudera.org:8080/24216
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_event_processing.py
M tests/metadata/test_event_processing_base.py
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Csaba Ringhofer: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib89c6f1928a1190942ec3c8001e0d8671d896857
Gerrit-Change-Number: 24216
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>