You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "seokjin0414 (via GitHub)" <gi...@apache.org> on 2026/07/16 13:48:51 UTC

[PR] test(bdd): fail Go BDD runner on undefined steps [iggy]

seokjin0414 opened a new pull request, #3681:
URL: https://github.com/apache/iggy/pull/3681

   Follow-up to #3554 — Go half of #3634 (Rust half in #3680).
   
   godog is non-strict by default and neither `godog.Options` block set `Strict`, so a step without a matching definition in the Go runner is reported as undefined while `go test` still exits 0 and CI stays green. Both suites now set `Strict: true`; the existing `s.Run() != 0` check turns that into a test failure.
   
   Verification (local server with `--with-default-root-credentials`, fresh data dir per run):
   - green path: `BDD_FEATURE=basic_messaging go test -count=1 ./tests/` → exit 0, `17 steps (17 passed)`
   - red path (repro from #3634: bogus step appended to the feature): exit 1, `1 scenarios (1 undefined)` → FAIL
   - `gofmt` / `go vet` clean
   
   Refs #3634


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(bdd): fail Go BDD runner on undefined steps [iggy]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3681:
URL: https://github.com/apache/iggy/pull/3681#issuecomment-4992781930

   ## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3681?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 73.15%. Comparing base ([`313c50b`](https://app.codecov.io/gh/apache/iggy/commit/313c50bba41efcbf7b6129971fa8e750bfc5ee2a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e0452db`](https://app.codecov.io/gh/apache/iggy/commit/e0452dba0dc3926e82b17616cc9b794b955d5a71?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3681      +/-   ##
   ============================================
   - Coverage     73.98%   73.15%   -0.83%     
     Complexity      937      937              
   ============================================
     Files          1301     1301              
     Lines        147354   147354              
     Branches     122911   122911              
   ============================================
   - Hits         109013   107790    -1223     
   - Misses        34868    36181    +1313     
   + Partials       3473     3383      -90     
   ```
   
   | [Components](https://app.codecov.io/gh/apache/iggy/pull/3681/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3681/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.28% <ø> (ø)` | |
   | [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3681/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.44% <ø> (ø)` | |
   | [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3681/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.18% <ø> (ø)` | |
   | [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3681/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.17% <ø> (ø)` | |
   | [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3681/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.29% <ø> (ø)` | |
   | [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3681/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.26% <ø> (ø)` | |
   | [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3681/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.94% <ø> (-25.78%)` | :arrow_down: |
   [see 42 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3681/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(bdd): fail Go BDD runner on undefined steps [iggy]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3681:
URL: https://github.com/apache/iggy/pull/3681#issuecomment-4992668006

   <!-- iggy-pr-triage-welcome -->
   Thanks for the PR. It is labeled `S-waiting-on-review` and queued for review.
   
   Slash commands (own line, regular comment) move it around the queue:
   
   - `/ready` - back to `S-waiting-on-review` after addressing feedback
   - `/author` - flip to `S-waiting-on-author` while you finish changes
   - `/request-review @user-or-team` - request a reviewer
   
   See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md#pr-triage-commands) for details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(bdd): fail Go BDD runner on undefined steps [iggy]

Posted by "seokjin0414 (via GitHub)" <gi...@apache.org>.
seokjin0414 commented on PR #3681:
URL: https://github.com/apache/iggy/pull/3681#issuecomment-5002648395

   @hubcio could you take a look at this one as well? go half of #3634, same fix as the rust one (#3680) you approved — 2-line diff. CI is re-running after a rebase onto latest master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(bdd): fail Go BDD runner on undefined steps [iggy]

Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #3681:
URL: https://github.com/apache/iggy/pull/3681


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org