You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/03/20 22:47:13 UTC
[kudu-CR] [mini kdc] MiniKdc::Kinit() atomically replaces ccache
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15516
Change subject: [mini_kdc] MiniKdc::Kinit() atomically replaces ccache
......................................................................
[mini_kdc] MiniKdc::Kinit() atomically replaces ccache
This patch updates implementation of MiniKdc::Kinit() to atomically
replace cache credentials file. I noticed that without this patch
Java test TestSecurity.testRenewAndReacquireKerberosCredentials
fails time to time in a TSAN build, but with this patch and with
https://gerrit.cloudera.org/#/c/15433/ it passes every time.
Change-Id: I44b0afc1d92519f9942b8a6dfb14ebc12eda0949
---
M src/kudu/security/test/mini_kdc.cc
1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/15516/1
--
To view, visit http://gerrit.cloudera.org:8080/15516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44b0afc1d92519f9942b8a6dfb14ebc12eda0949
Gerrit-Change-Number: 15516
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini kdc] MiniKdc::Kinit() atomically replaces ccache
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15516 )
Change subject: [mini_kdc] MiniKdc::Kinit() atomically replaces ccache
......................................................................
[mini_kdc] MiniKdc::Kinit() atomically replaces ccache
This patch updates implementation of MiniKdc::Kinit() to atomically
replace cache credentials file. I noticed that without this patch
Java test TestSecurity.testRenewAndReacquireKerberosCredentials
fails time to time in a TSAN build, but with this patch and with
https://gerrit.cloudera.org/#/c/15433/ it passes every time.
Change-Id: I44b0afc1d92519f9942b8a6dfb14ebc12eda0949
Reviewed-on: http://gerrit.cloudera.org:8080/15516
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/security/test/mini_kdc.cc
1 file changed, 20 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I44b0afc1d92519f9942b8a6dfb14ebc12eda0949
Gerrit-Change-Number: 15516
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [mini kdc] MiniKdc::Kinit() atomically replaces ccache
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15516 )
Change subject: [mini_kdc] MiniKdc::Kinit() atomically replaces ccache
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b0afc1d92519f9942b8a6dfb14ebc12eda0949
Gerrit-Change-Number: 15516
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Mar 2020 23:02:19 +0000
Gerrit-HasComments: No