You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/01 11:59:32 UTC
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery
codecov[bot] edited a comment on pull request #5120:
URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=h1) Report
> Merging [#5120](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/118e334e7c46e2475e0e7a616b185cdef63d5302&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `52.38%`.
[](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5120 +/- ##
============================================
+ Coverage 53.08% 53.16% +0.08%
+ Complexity 3166 2998 -168
============================================
Files 820 781 -39
Lines 20508 19519 -989
Branches 1972 1926 -46
============================================
- Hits 10887 10378 -509
+ Misses 8739 8281 -458
+ Partials 882 860 -22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5120/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `46.87% <16.66%> (-32.38%)` | `0.00 <0.00> (ø)` | |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5120/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `62.65% <25.00%> (+2.88%)` | `13.00 <0.00> (-1.00)` | :arrow_up: |
| [...apache/skywalking/apm/agent/core/boot/Address.java](https://codecov.io/gh/apache/skywalking/pull/5120/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9BZGRyZXNzLmphdmE=) | `35.71% <35.71%> (ø)` | `2.00 <2.00> (?)` | |
| [.../agent/core/discovery/DefaultDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/5120/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGlzY292ZXJ5L0RlZmF1bHREaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `76.92% <76.92%> (ø)` | `7.00 <7.00> (?)` | |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/5120/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `60.00% <100.00%> (+3.58%)` | `12.00 <0.00> (ø)` | |
| [...tion/apollo/ApolloConfigurationCenterSettings.java](https://codecov.io/gh/apache/skywalking/pull/5120/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwb2xsby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBvbGxvL0Fwb2xsb0NvbmZpZ3VyYXRpb25DZW50ZXJTZXR0aW5ncy5qYXZh) | `20.68% <0.00%> (-79.32%)` | `1.00% <0.00%> (ø%)` | |
| [...nfiguration/zookeeper/ZookeeperServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/5120/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLXpvb2tlZXBlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vem9va2VlcGVyL1pvb2tlZXBlclNlcnZlclNldHRpbmdzLmphdmE=) | `71.42% <0.00%> (-28.58%)` | `1.00% <0.00%> (ø%)` | |
| [.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5120/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=) | `32.25% <0.00%> (-17.75%)` | `9.00% <0.00%> (+2.00%)` | :arrow_down: |
| [...g/oap/server/library/server/jetty/JettyServer.java](https://codecov.io/gh/apache/skywalking/pull/5120/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2pldHR5L0pldHR5U2VydmVyLmphdmE=) | `50.00% <0.00%> (-7.70%)` | `5.00% <0.00%> (ø%)` | |
| ... and [114 more](https://codecov.io/gh/apache/skywalking/pull/5120/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=footer). Last update [118e334...1c83209](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org