[geode] branch feature/GEODE-6291 updated: fixed SqlToPdxInstanceCreatorTest

[ds...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dschneider pushed a commit to branch feature/GEODE-6291
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/feature/GEODE-6291 by this push:
     new 65e14ed  fixed SqlToPdxInstanceCreatorTest
65e14ed is described below

commit 65e14ed55193eaf3681bbb6a81e4d8125ca07162
Author: Darrel Schneider <ds...@pivotal.io>
AuthorDate: Tue Feb 19 18:13:05 2019 -0800

    fixed SqlToPdxInstanceCreatorTest
---
 .../jdbc/internal/SqlToPdxInstanceCreatorTest.java | 27 ----------------------
 1 file changed, 27 deletions(-)

diff --git a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/SqlToPdxInstanceCreatorTest.java b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/SqlToPdxInstanceCreatorTest.java
index 046e01a..b808379 100644
--- a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/SqlToPdxInstanceCreatorTest.java
+++ b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/SqlToPdxInstanceCreatorTest.java
@@ -14,7 +14,6 @@
  */
 package org.apache.geode.connectors.jdbc.internal;
 
-import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
@@ -22,7 +21,6 @@ import static org.mockito.Mockito.when;
 import java.sql.JDBCType;
 import java.sql.SQLException;
 import java.util.Arrays;
-import java.util.Map;
 
 import junitparams.JUnitParamsRunner;
 import junitparams.Parameters;
@@ -32,14 +30,12 @@ import org.junit.Test;
 import org.junit.rules.ExpectedException;
 import org.junit.runner.RunWith;
 
-import org.apache.geode.connectors.jdbc.internal.SqlToPdxInstance.PdxFieldInfo;
 import org.apache.geode.connectors.jdbc.internal.configuration.FieldMapping;
 import org.apache.geode.connectors.jdbc.internal.configuration.RegionMapping;
 import org.apache.geode.internal.cache.InternalCache;
 import org.apache.geode.pdx.FieldType;
 import org.apache.geode.pdx.PdxInstance;
 import org.apache.geode.pdx.PdxInstanceFactory;
-import org.apache.geode.pdx.internal.TypeRegistry;
 
 @RunWith(JUnitParamsRunner.class)
 public class SqlToPdxInstanceCreatorTest {
@@ -85,29 +81,6 @@ public class SqlToPdxInstanceCreatorTest {
     verify(factory).create();
   }
 
-  @Test
-  public void pdxFieldGeneratedFromColumnNameAndTypeGivenNoPdxNameAndNoTypeInRegistry()
-      throws Exception {
-    PdxInstanceFactory factory = setupPdxInstanceFactory(null);
-    when(columnMapping.getJdbcType()).thenReturn(JDBCType.VARCHAR.name());
-    when(columnMapping.getPdxName()).thenReturn("");
-    when(columnMapping.getPdxType()).thenReturn("");
-    TypeRegistry typeRegistry = mock(TypeRegistry.class);
-    when(cache.getPdxRegistry()).thenReturn(typeRegistry);
-
-    SqlToPdxInstance result = createSqlToPdxInstance();
-
-    verify(factory).writeString(COLUMN_NAME_1, null);
-    verify(factory).create();
-    assertThat(result).isNotNull();
-    assertThat(result.getPdxTemplate()).isSameAs(pdxTemplate);
-    Map<String, PdxFieldInfo> map = result.getColumnToPdxFieldMap();
-    assertThat(map).hasSize(1);
-    assertThat(map).containsKey(COLUMN_NAME_1);
-    assertThat(map.get(COLUMN_NAME_1).getName()).isEqualTo(COLUMN_NAME_1);
-    assertThat(map.get(COLUMN_NAME_1).getType()).isEqualTo(FieldType.STRING);
-  }
-
   private SqlToPdxInstance createSqlToPdxInstance() throws SQLException {
     SqlToPdxInstanceCreator sqlToPdxInstanceCreator =
         new SqlToPdxInstanceCreator(cache, regionMapping);