You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2023/04/24 13:08:29 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #23794: docs: discourage the use of SQLite
dpgaspar opened a new pull request, #23794:
URL: https://github.com/apache/superset/pull/23794
### SUMMARY
Make docs more explicit that using a SQLite metadata DB is highly not advisable.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #23794: docs: discourage the use of SQLite
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #23794:
URL: https://github.com/apache/superset/pull/23794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #23794: docs: discourage the use of SQLite
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #23794:
URL: https://github.com/apache/superset/pull/23794#discussion_r1175520561
##########
docs/docs/installation/configuring-superset.mdx:
##########
@@ -71,9 +71,11 @@ WTF_CSRF_EXEMPT_LIST = [‘’]
### Using a production metastore
-By default Superset is configured to use SQLite, it's a simple and fast way to get you started
-(no installation needed). But for production environments you should use a different database engine on
-a separate host or container.
+By default, Superset is configured to use SQLite, which is a simple and fast way to get started
+(without requiring any installation). However, for production environments,
+using SQLite is highly discouraged due to security, scalability, and data integrity reasons.
+It's important to use only the supported database engines and consider using a different
Review Comment:
```suggestion
It's important to use only supported database engines and consider using a different
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #23794: docs: discourage the use of SQLite
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #23794:
URL: https://github.com/apache/superset/pull/23794#discussion_r1177882333
##########
docs/docs/installation/configuring-superset.mdx:
##########
@@ -71,9 +71,11 @@ WTF_CSRF_EXEMPT_LIST = [‘’]
### Using a production metastore
-By default Superset is configured to use SQLite, it's a simple and fast way to get you started
-(no installation needed). But for production environments you should use a different database engine on
-a separate host or container.
+By default, Superset is configured to use SQLite, which is a simple and fast way to get started
+(without requiring any installation). However, for production environments,
+using SQLite is highly discouraged due to security, scalability, and data integrity reasons.
+It's important to use only the supported database engines and consider using a different
+database engine on a separate host or container.
Review Comment:
shorter but seems a bit confusing to say "another supported database engine on a separate host"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #23794: docs: discourage the use of SQLite
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #23794:
URL: https://github.com/apache/superset/pull/23794#discussion_r1175524149
##########
docs/docs/installation/configuring-superset.mdx:
##########
@@ -71,9 +71,11 @@ WTF_CSRF_EXEMPT_LIST = [‘’]
### Using a production metastore
-By default Superset is configured to use SQLite, it's a simple and fast way to get you started
-(no installation needed). But for production environments you should use a different database engine on
-a separate host or container.
+By default, Superset is configured to use SQLite, which is a simple and fast way to get started
+(without requiring any installation). However, for production environments,
+using SQLite is highly discouraged due to security, scalability, and data integrity reasons.
+It's important to use only the supported database engines and consider using a different
+database engine on a separate host or container.
Review Comment:
```suggestion
We recommend using another supported database engine on a separate host or container.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org