You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/31 02:05:15 UTC
[GitHub] [apisix] hf400159 opened a new pull request, #7170: docs: update skywalking Chinese doc
hf400159 opened a new pull request, #7170:
URL: https://github.com/apache/apisix/pull/7170
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #7170:
URL: https://github.com/apache/apisix/pull/7170#discussion_r890689036
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -1,5 +1,11 @@
---
title: skywalking
+keywords:
+ - APISIX
+ - Plugin
+ - SkyWalking
+ - skywalking
Review Comment:
Please just keep using `SkyWalking`, the same to other documents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #7170:
URL: https://github.com/apache/apisix/pull/7170#discussion_r890689036
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -1,5 +1,11 @@
---
title: skywalking
+keywords:
+ - APISIX
+ - Plugin
+ - SkyWalking
+ - skywalking
Review Comment:
Please just keep using `SkyWalking`, the same as other documents. No need to mention a keyword multiple times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] hf400159 commented on a diff in pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
hf400159 commented on code in PR #7170:
URL: https://github.com/apache/apisix/pull/7170#discussion_r889787410
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -1,5 +1,11 @@
---
title: skywalking
+keywords:
+ - APISIX
+ - Plugin
+ - SkyWalking
+ - skywalking
Review Comment:
We are currently unsure which keywords will be helpful for this document. So keep it consistent. https://github.com/apache/apisix/pull/6883#pullrequestreview-949748616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a diff in pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
moonming commented on code in PR #7170:
URL: https://github.com/apache/apisix/pull/7170#discussion_r889638318
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -1,5 +1,11 @@
---
title: skywalking
+keywords:
+ - APISIX
+ - Plugin
+ - SkyWalking
+ - skywalking
+description: 本篇文档主要介绍 Apache APISIX skywalking 插件的基本信息及使用方法。
Review Comment:
```suggestion
description: 介绍 Apache SkyWalking（一个开源的 APM） 在 API 网关 Apache APISIX 中的使用方法。
```
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -1,5 +1,11 @@
---
title: skywalking
+keywords:
+ - APISIX
+ - Plugin
+ - SkyWalking
+ - skywalking
Review Comment:
What is the difference between them?
##########
docs/zh/latest/FAQ.md:
##########
@@ -594,6 +594,6 @@ apisix:
## 如果在使用 APISIX 过程中遇到问题，我可以在哪里寻求更多帮助？
-- [Apache APISIX Slack Channel](/docs/general/community#joining-the-slack-channel)：加入后请选择 channel-apisix 频道，即可通过此频道进行 APISIX 相关问题的提问。
-- [邮件列表](/docs/general/community#joining-the-mailing-list)：任何问题或对项目提议都可以通过社区邮件进行讨论。
+- [Apache APISIX Slack Channel](/docs/general/join/#加入-slack-频道)：加入后请选择 channel-apisix 频道，即可通过此频道进行 APISIX 相关问题的提问。
+- [邮件列表](/docs/general/join/#订阅邮件列表)：任何问题或对项目提议都可以通过社区邮件进行讨论。
Review Comment:
These changes have nothing to do with the title, please remove
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -23,30 +29,94 @@ title: skywalking
## 描述
-[**SkyWalking**](https://github.com/apache/skywalking) 使用其原生的 Nginx LUA tracer 提供分布式追踪、拓扑分析以及服务和 URI 级别的 metrics 信息。
+`skywalking` 插件用于与 [Apache SkyWalking](https://github.com/apache/skywalking) 集成。
+
+SkyWalking 使用其原生的 NGINX Lua tracer 从服务和 URI 角度提供了分布式追踪、拓扑分析以及 metrics 。
-服务端目前支持 HTTP 和 gRPC 两种协议，在 APISIX 中目前只支持 HTTP 协议。
+APISIX 仅支持使用 HTTP 协议与 SkyWalking 服务器进行交互。
Review Comment:
I think `服务端目前支持 HTTP 和 gRPC 两种协议，在 APISIX 中目前只支持 HTTP 协议。` is better.
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -1,5 +1,11 @@
---
title: skywalking
+keywords:
+ - APISIX
+ - Plugin
+ - SkyWalking
+ - skywalking
+description: 本篇文档主要介绍 Apache APISIX skywalking 插件的基本信息及使用方法。
Review Comment:
please update the English desc too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] hf400159 commented on a diff in pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
hf400159 commented on code in PR #7170:
URL: https://github.com/apache/apisix/pull/7170#discussion_r889785443
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -1,5 +1,11 @@
---
title: skywalking
+keywords:
+ - APISIX
+ - Plugin
+ - SkyWalking
+ - skywalking
Review Comment:
We are not sure which keywords users will search by, so we use keywords with different capitalization. It will be optimized based on SEO in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on code in PR #7170:
URL: https://github.com/apache/apisix/pull/7170#discussion_r886241546
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -69,102 +139,83 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1
}'
```
-你也可以通过 web 界面来完成上面的操作，先增加一个 route，然后在插件页面中添加 SkyWalking 插件：
-
-
+<!-- 你也可以通过 web 界面来完成上面的操作，先增加一个 route，然后在插件页面中添加 SkyWalking 插件：
-## 如何设置 Endpoint
+ -->
-我们可以通过指定 `conf/config.yaml` 中的配置来指定 endpoint：
-
-| 名称 | 类型 | 默认值 | 描述 |
-| ------------ | ------ | -------- | ----------------------------------------------------- |
-| service_name | string | "APISIX" | SkyWalking 上报的 service 名称 |
-| service_instance_name | string | "APISIX Instance Name" | SkyWalking 上报的 service 实例名，如果期望直接获取本机主机名则设置为 `$hostname` |
-| endpoint_addr | string | "http://127.0.0.1:12800" | SkyWalking 的 HTTP endpoint 地址，例如：http://127.0.0.1:12800 |
-| report_interval | integer | 使用 SkyWalking 客户端内置的值 | 上报时间间隔，单位是秒 |
+## 测试插件
-配置示例：
+首先你可以通过以下命令启动 SkyWalking OAP 服务：
-```yaml
-plugin_attr:
- skywalking:
- service_name: APISIX
- service_instance_name: "APISIX Instance Name"
- endpoint_addr: http://127.0.0.1:12800
+```shell
+sudo docker run \
+--name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 \
+--restart always apache/skywalking-oap-server:8.7.0-es6
```
-## 测试插件
-
-### 运行 SkyWalking 实例
-
-#### 例子：
+:::tip
-1. 启动 SkyWalking OAP 服务：
- - SkyWalking 默认使用 H2 存储，可直接启动
+SkyWalking 默认使用 H2 存储。你也可以使用 Elasticsearch 存储：
- ```shell
- sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always apache/skywalking-oap-server:8.7.0-es6
- ```
+首先你可以通过以下命令安装 Elasticsearch：
- - 也许你会更倾向于使用 Elasticsearch 存储
- 1. 则需要先安装 Elasticsearch:
+```shell
+sudo docker run -d --name elasticsearch -p 9200:9200 -p 9300:9300 \
+--restart always -e "discovery.type=single-node" elasticsearch:6.7.2
+```
- ```shell
- sudo docker run -d --name elasticsearch -p 9200:9200 -p 9300:9300 --restart always -e "discovery.type=single-node" elasticsearch:6.7.2
- ```
+你也可以安装 ElasticSearch 管理界面 elasticsearch-hq：
- 2.【可选】安装 ElasticSearch 管理界面 elasticsearch-hq
+ ```shell
+sudo docker run -d --name elastic-hq -p 5000:5000 --restart always elastichq/elasticsearch-hq
+```
- ```shell
- sudo docker run -d --name elastic-hq -p 5000:5000 --restart always elastichq/elasticsearch-hq
- ```
+最后，你可以通过以下命令启动 SkyWalking OAP 服务：
- 3. 启动 SkyWalking OAP 服务：
+```shell
+sudo docker run \
+--name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 \
+--restart always \
+--link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch \
+-e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server:8.7.0-es6
+```
- ```shell
- sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server:8.7.0-es6
- ```
+:::
-2. SkyWalking Web UI：
- 1. 启动管理系统：
+你可以使用以下命令启动 SkyWalking UI 查看数据：
- ```shell
- sudo docker run --name skywalking-ui -d -p 8080:8080 --link skywalking:skywalking -e SW_OAP_ADDRESS=skywalking:12800 --restart always apache/skywalking-ui
- ```
+```shell
+sudo docker run --name skywalking-ui -d -p 8080:8080 \
+--link skywalking:skywalking -e SW_OAP_ADDRESS=skywalking:12800 \
+--restart always apache/skywalking-ui
+```
- 2. 打开 Web UI 页面
- 在浏览器里面输入 http://10.110.149.175:8080 如出现如下界面，则表示安装成功
+接下来你可以通过以下命令访问 APISIX
- 
+```shell
+curl -v http://10.110.149.192:9080/uid/12
+```
-3. 测试示例：
- - 通过访问 APISIX，访问上游服务
+```
+HTTP/1.1 200 OK
+OK
+...
+```
- ```bash
- $ curl -v http://10.110.149.192:9080/uid/12
- HTTP/1.1 200 OK
- OK
- ...
- ```
+完成上述步骤后，打开浏览器，访问 SkyWalking 的 UI 页面，你可以看到服务拓扑图：
Review Comment:
```suggestion
完成上述步骤后，打开浏览器，访问 SkyWalking 的 UI 页面，你可以看到如下服务拓扑图：
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #7170:
URL: https://github.com/apache/apisix/pull/7170#discussion_r890689481
##########
docs/en/latest/plugins/skywalking.md:
##########
@@ -5,7 +5,7 @@ keywords:
- Plugin
- SkyWalking
- skywalking
-description: This document contains information about the Apache skywalking Plugin.
+description: This article will introduce how the API gateway Apache APISIX reports metrics to Apache SkyWalking (an open source APM) through the skywalking plugin.
Review Comment:
```suggestion
description: This document will introduce how the API gateway Apache APISIX reports metrics to Apache SkyWalking (an open-source APM) with the skywalking plugin.
```
##########
docs/en/latest/plugins/zipkin.md:
##########
@@ -1,5 +1,5 @@
---
-title: Zipkin
+title: zipkin
Review Comment:
We'd better keep one PR for one thing 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on code in PR #7170:
URL: https://github.com/apache/apisix/pull/7170#discussion_r886241480
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -69,102 +139,83 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1
}'
```
-你也可以通过 web 界面来完成上面的操作，先增加一个 route，然后在插件页面中添加 SkyWalking 插件：
-
-
+<!-- 你也可以通过 web 界面来完成上面的操作，先增加一个 route，然后在插件页面中添加 SkyWalking 插件：
-## 如何设置 Endpoint
+ -->
-我们可以通过指定 `conf/config.yaml` 中的配置来指定 endpoint：
-
-| 名称 | 类型 | 默认值 | 描述 |
-| ------------ | ------ | -------- | ----------------------------------------------------- |
-| service_name | string | "APISIX" | SkyWalking 上报的 service 名称 |
-| service_instance_name | string | "APISIX Instance Name" | SkyWalking 上报的 service 实例名，如果期望直接获取本机主机名则设置为 `$hostname` |
-| endpoint_addr | string | "http://127.0.0.1:12800" | SkyWalking 的 HTTP endpoint 地址，例如：http://127.0.0.1:12800 |
-| report_interval | integer | 使用 SkyWalking 客户端内置的值 | 上报时间间隔，单位是秒 |
+## 测试插件
-配置示例：
+首先你可以通过以下命令启动 SkyWalking OAP 服务：
-```yaml
-plugin_attr:
- skywalking:
- service_name: APISIX
- service_instance_name: "APISIX Instance Name"
- endpoint_addr: http://127.0.0.1:12800
+```shell
+sudo docker run \
+--name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 \
+--restart always apache/skywalking-oap-server:8.7.0-es6
```
-## 测试插件
-
-### 运行 SkyWalking 实例
-
-#### 例子：
+:::tip
-1. 启动 SkyWalking OAP 服务：
- - SkyWalking 默认使用 H2 存储，可直接启动
+SkyWalking 默认使用 H2 存储。你也可以使用 Elasticsearch 存储：
- ```shell
- sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always apache/skywalking-oap-server:8.7.0-es6
- ```
+首先你可以通过以下命令安装 Elasticsearch：
- - 也许你会更倾向于使用 Elasticsearch 存储
- 1. 则需要先安装 Elasticsearch:
+```shell
+sudo docker run -d --name elasticsearch -p 9200:9200 -p 9300:9300 \
+--restart always -e "discovery.type=single-node" elasticsearch:6.7.2
+```
- ```shell
- sudo docker run -d --name elasticsearch -p 9200:9200 -p 9300:9300 --restart always -e "discovery.type=single-node" elasticsearch:6.7.2
- ```
+你也可以安装 ElasticSearch 管理界面 elasticsearch-hq：
- 2.【可选】安装 ElasticSearch 管理界面 elasticsearch-hq
+ ```shell
+sudo docker run -d --name elastic-hq -p 5000:5000 --restart always elastichq/elasticsearch-hq
+```
- ```shell
- sudo docker run -d --name elastic-hq -p 5000:5000 --restart always elastichq/elasticsearch-hq
- ```
+最后，你可以通过以下命令启动 SkyWalking OAP 服务：
- 3. 启动 SkyWalking OAP 服务：
+```shell
+sudo docker run \
+--name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 \
+--restart always \
+--link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch \
+-e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server:8.7.0-es6
+```
- ```shell
- sudo docker run --name skywalking -d -p 1234:1234 -p 11800:11800 -p 12800:12800 --restart always --link elasticsearch:elasticsearch -e SW_STORAGE=elasticsearch -e SW_STORAGE_ES_CLUSTER_NODES=elasticsearch:9200 apache/skywalking-oap-server:8.7.0-es6
- ```
+:::
-2. SkyWalking Web UI：
- 1. 启动管理系统：
+你可以使用以下命令启动 SkyWalking UI 查看数据：
- ```shell
- sudo docker run --name skywalking-ui -d -p 8080:8080 --link skywalking:skywalking -e SW_OAP_ADDRESS=skywalking:12800 --restart always apache/skywalking-ui
- ```
+```shell
+sudo docker run --name skywalking-ui -d -p 8080:8080 \
+--link skywalking:skywalking -e SW_OAP_ADDRESS=skywalking:12800 \
+--restart always apache/skywalking-ui
+```
- 2. 打开 Web UI 页面
- 在浏览器里面输入 http://10.110.149.175:8080 如出现如下界面，则表示安装成功
+接下来你可以通过以下命令访问 APISIX
Review Comment:
```suggestion
接下来你可以通过以下命令访问 APISIX：
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on code in PR #7170:
URL: https://github.com/apache/apisix/pull/7170#discussion_r886240891
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -23,30 +29,94 @@ title: skywalking
## 描述
-[**SkyWalking**](https://github.com/apache/skywalking) 使用其原生的 Nginx LUA tracer 提供分布式追踪、拓扑分析以及服务和 URI 级别的 metrics 信息。
+`skywalking` 插件用于与 [Apache SkyWalking](https://github.com/apache/skywalking) 集成。
+
+SkyWalking 使用其原生的 NGINX Lua tracer 从服务和 URI 角度提供了分布式追踪、拓扑分析以及 metrics 。
-服务端目前支持 HTTP 和 gRPC 两种协议，在 APISIX 中目前只支持 HTTP 协议。
+APISIX 仅支持使用 HTTP 协议与 SkyWalking 服务器进行交互。
## 属性
-| 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 |
-| ------------ | ------ | ------ | -------- | ------------ | ----------------------------------------------------- |
-| sample_ratio | number | 必须 | 1 | [0.00001, 1] | 采样的比例 |
+| 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 |
+| ------------ | ------ | ------ | ------ | ------------ | ----------------------------------------------------- |
+| sample_ratio | number | 是 | 1 | [0.00001, 1] | 采样的比例。设置为 `1` 时，将对所有请求进行采样。 |
+
+### 如何设置 Endpoint
+
+你可以在配置文件（`./conf/config.yaml`）中配置以下属性：
-## 如何启用
+| 名称 | 类型 | 默认值 | 描述 |
+| --------------------- | ------- | ------------------------ | ------------------------------------------------------------------ |
+| service_name | string | "APISIX" | SkyWalking 上报的服务名称。 |
Review Comment:
```suggestion
| service_name | string | "APISIX" | SkyWalking 上报的服务名称。 |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan merged pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged PR #7170:
URL: https://github.com/apache/apisix/pull/7170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on code in PR #7170:
URL: https://github.com/apache/apisix/pull/7170#discussion_r886241768
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -181,58 +232,10 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335
}'
```
-现在就已经移除了 SkyWalking 插件了。其他插件的开启和移除也是同样的方法。
-
-如果你想完全禁用 SkyWalking 插件，比如停掉后台上报数据的定时器，需要在 `config.yaml` 里把插件注释掉：
+如果你想完全禁用 SkyWalking 插件，即停掉后台上报数据的定时器，就需要从配置文件（`./conf/config.yaml`）注释该插件：
Review Comment:
```suggestion
如果你想完全禁用 `skywalking` 插件，即停掉后台上报数据的定时器，就需要从配置文件（`./conf/config.yaml`）注释该插件：
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY commented on pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on PR #7170:
URL: https://github.com/apache/apisix/pull/7170#issuecomment-1142952978
others LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7170: docs: update skywalking Chinese doc
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on code in PR #7170:
URL: https://github.com/apache/apisix/pull/7170#discussion_r889785025
##########
docs/zh/latest/plugins/skywalking.md:
##########
@@ -23,30 +29,94 @@ title: skywalking
## 描述
-[**SkyWalking**](https://github.com/apache/skywalking) 使用其原生的 Nginx LUA tracer 提供分布式追踪、拓扑分析以及服务和 URI 级别的 metrics 信息。
+`skywalking` 插件用于与 [Apache SkyWalking](https://github.com/apache/skywalking) 集成。
+
+SkyWalking 使用其原生的 NGINX Lua tracer 从服务和 URI 角度提供了分布式追踪、拓扑分析以及 metrics 。
-服务端目前支持 HTTP 和 gRPC 两种协议，在 APISIX 中目前只支持 HTTP 协议。
+服务端目前支持 HTTP 和 gRPC 两种协议，在 APISIX 中目前=只支持 HTTP 协议。
Review Comment:
```suggestion
服务端目前支持 HTTP 和 gRPC 两种协议，而在 APISIX 中目前只支持 HTTP 协议。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org