You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@twitter.com> on 2013/04/05 23:15:11 UTC
Review Request: Fixed exception tests to use the latest test abstractions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10318/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
See summary.
NOTE: It passed the tests and looked correct to me but please look closely for mistakes. Thanks for the help.
Diffs
-----
src/tests/exception_tests.cpp 5bc32440cf79fc40c27c78ddfa47871ccdb11e20
Diff: https://reviews.apache.org/r/10318/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="*ExceptionTest.**" --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle
Thanks,
Jiang Yan Xu
Re: Review Request: Fixed exception tests to use the latest test
abstractions.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10318/#review18767
-----------------------------------------------------------
src/tests/exception_tests.cpp
<https://reviews.apache.org/r/10318/#comment39180>
Move this down to line #90 where you call driver.abort().
src/tests/exception_tests.cpp
<https://reviews.apache.org/r/10318/#comment39181>
Move these above driver.abort()
- Vinod Kone
On April 5, 2013, 9:15 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10318/
> -----------------------------------------------------------
>
> (Updated April 5, 2013, 9:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
> NOTE: It passed the tests and looked correct to me but please look closely for mistakes. Thanks for the help.
>
>
> Diffs
> -----
>
> src/tests/exception_tests.cpp 5bc32440cf79fc40c27c78ddfa47871ccdb11e20
>
> Diff: https://reviews.apache.org/r/10318/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="*ExceptionTest.**" --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Fixed exception tests to use the latest test
abstractions.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10318/#review18874
-----------------------------------------------------------
Ship it!
- Ben Mahler
On April 5, 2013, 9:15 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10318/
> -----------------------------------------------------------
>
> (Updated April 5, 2013, 9:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
> NOTE: It passed the tests and looked correct to me but please look closely for mistakes. Thanks for the help.
>
>
> Diffs
> -----
>
> src/tests/exception_tests.cpp 5bc32440cf79fc40c27c78ddfa47871ccdb11e20
>
> Diff: https://reviews.apache.org/r/10318/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="*ExceptionTest.**" --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Fixed exception tests to use the latest test
abstractions.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10318/
-----------------------------------------------------------
(Updated April 9, 2013, 11:01 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Addressed vinodkone's comments.
Description
-------
See summary.
NOTE: It passed the tests and looked correct to me but please look closely for mistakes. Thanks for the help.
Diffs (updated)
-----
src/tests/exception_tests.cpp 5bc32440cf79fc40c27c78ddfa47871ccdb11e20
Diff: https://reviews.apache.org/r/10318/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="*ExceptionTest.**" --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle
Thanks,
Jiang Yan Xu