You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/11/24 03:32:35 UTC

[GitHub] [spark] nishkamravi2 commented on issue #26631: [SPARK-29992][CORE] Change getActive access to public

nishkamravi2 commented on issue #26631: [SPARK-29992][CORE] Change getActive access to public
URL: https://github.com/apache/spark/pull/26631#issuecomment-557854344
 
 
   Thanks for the feedback @srowen @dongjoon-hyun @rxin. If an application creates SparkContext outside of SparkSession (which unfortunately is still fairly prevalent), we don't have a public API to get activeContext. We can work around this by using a local org.apache.spark package to call this method or using reflection to bypass encapsulation. But avoiding the hack would have been preferable. I'm okay with closing this PR in the interest of not taking up community's time on something we couldn't quickly agree on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org