You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/28 10:22:36 UTC

[GitHub] [iotdb] cornmonster commented on a change in pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

cornmonster commented on a change in pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#discussion_r738250381



##########
File path: antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlLexer.g4
##########
@@ -913,43 +897,23 @@ NAN_LITERAL
  */
 
 ID
-    : FIRST_NAME_CHAR NAME_CHAR*
+    : NAME_CHAR+

Review comment:
       I am working on this issue: https://issues.apache.org/jira/browse/IOTDB-1886
   
   To support something like "SELECT 1 + s1 FROM root.sg.d1", we should not allow intergers to be identifiers. 
   
   Here is what I did: https://github.com/apache/iotdb/pull/4257




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org