You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by jf...@apache.org on 2007/09/21 13:55:09 UTC
svn commit: r578076 - /apr/apr-util/trunk/build/dbd.m4
Author: jfclere
Date: Fri Sep 21 04:55:06 2007
New Revision: 578076
URL: http://svn.apache.org/viewvc?rev=578076&view=rev
Log:
Oops was using the wrong variable.
Modified:
apr/apr-util/trunk/build/dbd.m4
Modified: apr/apr-util/trunk/build/dbd.m4
URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/build/dbd.m4?rev=578076&r1=578075&r2=578076&view=diff
==============================================================================
--- apr/apr-util/trunk/build/dbd.m4 (original)
+++ apr/apr-util/trunk/build/dbd.m4 Fri Sep 21 04:55:06 2007
@@ -445,12 +445,12 @@
# Use libtool *.la for mysql if available
if test $apu_have_mysql = 1; then
- for flag in $mysql_LDFLAGS
+ for flag in $LDADD_dbd_mysql
do
dir=`echo $flag | grep "^-L" | sed s:-L::`
if test "x$dir" != 'x'; then
if test -f "$dir/libmysqlclient_r.la"; then
- mysql_LDFLAGS=$dir/libmysqlclient_r.la
+ LDADD_dbd_mysql=$dir/libmysqlclient_r.la
break
fi
fi
Re: svn commit: r578076 - /apr/apr-util/trunk/build/dbd.m4
Posted by Joe Orton <jo...@redhat.com>.
On Mon, 2007-10-01 at 10:56 +1000, Bojan Smojver wrote:
> On Fri, 2007-09-21 at 11:55 +0000, jfclere@apache.org wrote:
> > Author: jfclere
> > Date: Fri Sep 21 04:55:06 2007
> > New Revision: 578076
> >
> > URL: http://svn.apache.org/viewvc?rev=578076&view=rev
> > Log:
> > Oops was using the wrong variable.
>
> Apparently, this and r578028 is causing people to not be able to link
> against APU unless libtool is used (e.g. when building PHP,
> http://news.php.net/php.general/262438). Could you have a look please?
This stuff should all be reverted for the reasons you gave in your
previous message - adding references to .la files in the LDADD_
variables is a non-starter since the references will make their way
through to the `apu-config --link-ld` output.
Jean-Frederic, can you explain exactly what the failure was which led to
this change in the first place?
joe
Re: svn commit: r578076 - /apr/apr-util/trunk/build/dbd.m4
Posted by Bojan Smojver <bo...@rexursive.com>.
On Fri, 2007-09-21 at 11:55 +0000, jfclere@apache.org wrote:
> Author: jfclere
> Date: Fri Sep 21 04:55:06 2007
> New Revision: 578076
>
> URL: http://svn.apache.org/viewvc?rev=578076&view=rev
> Log:
> Oops was using the wrong variable.
Apparently, this and r578028 is causing people to not be able to link
against APU unless libtool is used (e.g. when building PHP,
http://news.php.net/php.general/262438). Could you have a look please?
--
Bojan