You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/08 12:18:21 UTC
[jira] [Commented] (KAFKA-4266) Replication Quota Tests: Ensure ZK
updated before tests start
[ https://issues.apache.org/jira/browse/KAFKA-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15557872#comment-15557872 ]
ASF GitHub Bot commented on KAFKA-4266:
---------------------------------------
GitHub user benstopford opened a pull request:
https://github.com/apache/kafka/pull/1997
KAFKA-4266: ReassignPartitionsClusterTest - Ensure ZK publication completed before start
Increase the reliability of the one temporal comparison in ReassignPartitionsClusterTest by imposing a delay after ZK is updated. This should be more reliable than just increasing the amount of data.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benstopford/kafka KAFKA-4266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1997.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1997
----
commit 010b0b6a1a23d6297c62417aa4165b2c89142e1d
Author: Ben Stopford <be...@gmail.com>
Date: 2016-10-07T10:01:16Z
KAFKA-4266 - check if each broker has had the throttled replicas updated before proceeding with the test (where applicable)
commit bcc9e1ab81ecd5537a64a15271a52712514d5820
Author: Ben Stopford <be...@gmail.com>
Date: 2016-10-08T11:57:00Z
KAFKA-4266 - revert prev change as it's not really useful
commit 9a243dbfe81d2ccc99a153d9693fafe535f15b07
Author: Ben Stopford <be...@gmail.com>
Date: 2016-10-08T12:03:16Z
KAFKA-4266 - add delay after ZK update for throttle config.
commit 7e9f0e90d3d8adfbf05635c3c3e6c16c0d9f5c00
Author: Ben Stopford <be...@gmail.com>
Date: 2016-10-08T12:16:59Z
KAFKA-4266 - formatting
----
> Replication Quota Tests: Ensure ZK updated before tests start
> -------------------------------------------------------------
>
> Key: KAFKA-4266
> URL: https://issues.apache.org/jira/browse/KAFKA-4266
> Project: Kafka
> Issue Type: Improvement
> Reporter: Ben Stopford
> Assignee: Ben Stopford
>
> Alter temporal test in ReassignPartitionsClusterTest so that it doesn't fail if ZK is not updated before throttle starts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)