You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/07/15 20:05:54 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request #3657: ARTEMIS-3388 URI query values decoded twice
jbertram opened a new pull request #3657:
URL: https://github.com/apache/activemq-artemis/pull/3657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram closed pull request #3657: ARTEMIS-3388 URI query values decoded twice
Posted by GitBox <gi...@apache.org>.
jbertram closed pull request #3657:
URL: https://github.com/apache/activemq-artemis/pull/3657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3657: ARTEMIS-3388 URI query values decoded twice
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3657:
URL: https://github.com/apache/activemq-artemis/pull/3657#discussion_r671614294
##########
File path: artemis-commons/src/test/java/org/apache/activemq/artemis/utils/URIParserTest.java
##########
@@ -58,9 +58,9 @@ public void testSchemaFruit() throws Throwable {
public void testGenerateWithEncoding() throws Throwable {
FruitParser parser = new FruitParser();
Fruit myFruit = new Fruit("tomato&fruit");
- myFruit.setHost("somehost&uui");
Review comment:
can we check both `&` and `%26` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #3657: ARTEMIS-3388 URI query values decoded twice
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on a change in pull request #3657:
URL: https://github.com/apache/activemq-artemis/pull/3657#discussion_r683806759
##########
File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/uri/BeanSupport.java
##########
@@ -148,7 +148,8 @@ public static String getData(List<String> ignored, Object... beans) throws Excep
sb.append("&");
}
empty = false;
- sb.append(descriptor.getName()).append("=").append(encodeURI(value));
+// sb.append(descriptor.getName()).append("=").append(encodeURI(value));
Review comment:
nit: commented out code (remove)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org