You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ciprian Ciubotariu <no...@github.com> on 2016/03/09 15:15:53 UTC
[jclouds] Version range specification for guava in OSGi (#934)
This PR changes jclouds' OSGi import directive for guava to allow version range [16.x-19.0]. This helps dependent projects mix jclouds with bundles using other guava versions within OSGi environments.
According to https://issues.apache.org/jira/browse/JCLOUDS-622 jclouds was made to use only guava classes that are compatible throughout guava versions, so this should be safe for the time being.
What are your thoughs on this? Is there better way to solve this package resolution problem?
P.S. The changes are based on the 1.9.x branch, because that's the version we use right now. I can port them to master if needed.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/934
-- Commit Summary --
* Improve version range specification for guava
-- File Changes --
M project/pom.xml (3)
M scriptbuilder/pom.xml (6)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/934.patch
https://github.com/jclouds/jclouds/pull/934.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Ignasi Barrera <no...@github.com>.
Closed #934.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934#event-591962681
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -83,6 +83,6 @@
> </configuration>
> </plugin>
> </plugins>
> - </build>
> + </build>-->
I'm not an OSGi expert, but could you please explain why this should be commented?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934/files#r55595004
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Svet <no...@github.com>.
+1, looks like this has already been discussed at https://issues.apache.org/jira/browse/JCLOUDS-534
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934#issuecomment-194322876
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Ignasi Barrera <no...@github.com>.
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/9a20cada) and [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/fc5f5e50). Thanks @CMoH!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934#issuecomment-197370364
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Ignasi Barrera <no...@github.com>.
Just one last sanity check now that the 1.9.x branch build is back to green: rebuild please
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934#issuecomment-196763824
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Andrew Gaul <no...@github.com>.
> @@ -206,6 +206,7 @@
> <maven.site.url.base>gitsite:git@github.com/jclouds/jclouds-maven-site.git</maven.site.url.base>
> <clojure.version>1.3.0</clojure.version>
> <guava.version>16.0.1</guava.version>
> + <guava.osgi.import>com.google.common.*;version="[16.0.1,19.0.0]"</guava.osgi.import>
Should this be half-closed notation, e.g., [16.0.1,20.0.0) ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934/files#r55601023
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Ignasi Barrera <no...@github.com>.
Just one last sanity check now that the 1.9.x branch build is back to green: rebuild, please
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934#issuecomment-196763743
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Ciprian Ciubotariu <no...@github.com>.
For reference, here is an analysis of guava's API compatibility across versions: http://upstream.rosalinux.ru/java/versions/guava.html
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934#issuecomment-194314513
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Ciprian Ciubotariu <no...@github.com>.
> @@ -83,6 +83,6 @@
> </configuration>
> </plugin>
> </plugins>
> - </build>
> + </build>-->
I added the guava version range override in `jclouds-project`, but `jclouds-scriptbuilder` didn't get them because it had these settings for `maven-bundle-plugin`. It appears to me that these are unnecessary, since they are exactly the same as in `jclouds-project` - maybe they were left here by accident?
At first I commented them out, but I think I'll simply remove them when updating the PR.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934/files#r55697956
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -206,6 +206,7 @@
> <maven.site.url.base>gitsite:git@github.com/jclouds/jclouds-maven-site.git</maven.site.url.base>
> <clojure.version>1.3.0</clojure.version>
> <guava.version>16.0.1</guava.version>
> + <guava.osgi.import>com.google.common.*;version="[16.0.1,19.0.0]"</guava.osgi.import>
FTR, these are the Guava versions we are compatible with (failed builds are due to transient issues):
https://jclouds.ci.cloudbees.com/job/jclouds-guava-guice-compat/
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934/files#r55602378
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Ciprian Ciubotariu <no...@github.com>.
> @@ -206,6 +206,7 @@
> <maven.site.url.base>gitsite:git@github.com/jclouds/jclouds-maven-site.git</maven.site.url.base>
> <clojure.version>1.3.0</clojure.version>
> <guava.version>16.0.1</guava.version>
> + <guava.osgi.import>com.google.common.*;version="[16.0.1,19.0.0]"</guava.osgi.import>
@andrewgaul Yeah, that is better. I'll update the PR.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934/files#r55696966
Re: [jclouds] Version range specification for guava in OSGi (#934)
Posted by Ignasi Barrera <no...@github.com>.
Looks like an unrelated failure. Let's trigger the build again: rebuild please
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934#issuecomment-195382545