[jira] [Commented] (CAMEL-5983) Avoid negative-tests to behave as false-positve

["Babak Vahdat (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558220#comment-13558220 ] 

Babak Vahdat commented on CAMEL-5983:
-------------------------------------

Fixed the tests *not* being false-postive on the trunk as well as the 2.10.x brunch:

http://svn.apache.org/viewvc?view=revision&revision=1435812
http://svn.apache.org/viewvc?view=revision&revision=1435814


                
> Avoid negative-tests to behave as false-positve
> -----------------------------------------------
>
>                 Key: CAMEL-5983
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5983
>             Project: Camel
>          Issue Type: Task
>          Components: tests
>    Affects Versions: 2.10.3
>            Reporter: Babak Vahdat
>
> We've got bunch of (negative) tests on the current codebase expecting a thrown {{XYZException}} however they don't realize if the expected exception is *not* thrown, the typical pattern for this is:
> {code}
> try {
>  doSomething_With_Expectation_Of_A_Thrown_XYZException();
> } catch (XYZException e) {
>  // expected
> }
> {code} 
> Which correctly should be:
> {code}
> try {
>  doSomething_With_Expectation_Of_A_Thrown_XYZException();
>  fail("Should have thrown an exception");
> } catch (XYZException e) {
>  // expected
> }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira