[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1126: system/note: correct unflatten format

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #1126:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1126#discussion_r843859122


##########
system/sched_note/note_main.c:
##########
@@ -94,18 +95,17 @@ static void trace_dump_unflatten(FAR void *dst,
     {
 #ifdef CONFIG_HAVE_LONG_LONG
       case 8:
-        *(uint64_t *)dst = ((uint64_t)src[7] << 56)
-                         + ((uint64_t)src[6] << 48)
-                         + ((uint64_t)src[5] << 40)
-                         + ((uint64_t)src[4] << 32);
+        *(uint64_t *)dst = le64toh(*(uint64_t *)src);

Review Comment:
   I have only one question. Are we sure that `src` is target type aligned? I mean that if `len == 4` then `src` can be promoted to `uint32_t *`. If not, then we will have troubles with archs that require pointers to be aligned. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org