[GitHub] [incubator-pinot] adriancole commented on a change in pull request #5917: Starts Broker and Server in parallel when using ServiceManager

[GitBox <gi...@apache.org>]

adriancole commented on a change in pull request #5917:
URL: https://github.com/apache/incubator-pinot/pull/5917#discussion_r476441553



##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java
##########
@@ -192,7 +192,20 @@ public boolean execute()
   }
 
   private void startPinotService(Map<String, Object> properties) {
-    startPinotService(ServiceRole.valueOf(properties.get(PINOT_SERVICE_ROLE).toString()), properties);
+    ServiceRole role = ServiceRole.valueOf(properties.get(PINOT_SERVICE_ROLE).toString());
+    switch (role) {
+      // Broker and Server can be started in parallel always
+      case BROKER:
+      case SERVER:

Review comment:
       intentionally left controller out of here as it seemed there was some reason to. Otherwise, I'd like to put it in :D




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org