svn commit: r1381571 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/ContentRepository.java

[mr...@apache.org]

Author: mreutegg
Date: Thu Sep  6 12:20:15 2012
New Revision: 1381571

URL: http://svn.apache.org/viewvc?rev=1381571&view=rev
Log:
Update JavaDoc.
I think we need to be more strict here. Otherwise we should remove the close() method from ContentSession.

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/ContentRepository.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/ContentRepository.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/ContentRepository.java?rev=1381571&r1=1381570&r2=1381571&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/ContentRepository.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/ContentRepository.java Thu Sep  6 12:20:15 2012
@@ -58,7 +58,7 @@ public interface ContentRepository {
      * rather take the arguments to be passed to the relevant
      * JAAS {@link javax.security.auth.login.LoginContext} constructor?
      * <p>
-     * The client should explicitly {@link ContentSession#close()} the
+     * The client must explicitly {@link ContentSession#close()} the
      * returned session once it is no longer used. The recommended access
      * pattern is:
      * <pre>

Re: svn commit: r1381571 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/ContentRepository.java

[Jukka Zitting <ju...@gmail.com>]

Hi,

On Thu, Sep 6, 2012 at 2:20 PM,  <mr...@apache.org> wrote:
> I think we need to be more strict here. Otherwise we should remove the close()
> method from ContentSession.

Hmm, good point.

I'd be in favor of removing the ContentSession.close() method if we
can. There shouldn't be any resources associated with a session that
normal garbage collection couldn't take care of.

BR,

Jukka Zitting