You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/20 20:30:56 UTC

[GitHub] [spark] tanelk commented on pull request #31907: [SPARK-34807][SQL] Move TransposeWindow before Operator push down

tanelk commented on pull request #31907:
URL: https://github.com/apache/spark/pull/31907#issuecomment-803459084


   Reordering the optimizers seems like a bit of a band-aid fix. 
   If I'm not mistaken the issue is similar to the one I tried to fix in #31677. The `CollapseWindow` rule did not work with `Project` nodes between windows. It seems, that the `TransposeWindow` has a similar problem.
   
   @cloud-fan did comment (https://github.com/apache/spark/pull/31677#issuecomment-800894675), that perhaps we should merge `Project` and `Window` nodes. But that seems like a major refacto of everything related to the logical `Window` nodes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org