You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2008/11/05 16:00:31 UTC

svn commit: r711582 - in /jakarta/jmeter/trunk: src/core/org/apache/jmeter/util/HttpSSLProtocolSocketFactory.java xdocs/changes.xml

Author: sebb
Date: Wed Nov  5 07:00:31 2008
New Revision: 711582

URL: http://svn.apache.org/viewvc?rev=711582&view=rev
Log:
Bug 46148 - HTTP sampler fails on SSL requests when logging for jmeter.util is set to DEBUG
Remove the debug code, as it has side effects

Modified:
    jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/HttpSSLProtocolSocketFactory.java
    jakarta/jmeter/trunk/xdocs/changes.xml

Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/HttpSSLProtocolSocketFactory.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/HttpSSLProtocolSocketFactory.java?rev=711582&r1=711581&r2=711582&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/HttpSSLProtocolSocketFactory.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/HttpSSLProtocolSocketFactory.java Wed Nov  5 07:00:31 2008
@@ -84,23 +84,6 @@
             throw new IllegalArgumentException("Expected SSLSocket");
         }
         SSLSocket sock = (SSLSocket) socket;
-        if (log.isDebugEnabled()) {
-            /* Warning: the next line seems to cause the error
-            * javax.net.ssl.SSLException: Received fatal alert: unexpected_message
-            * with certain sites
-            */
-            SSLSession sslSession = sock.getSession();
-            byte[] bytes = sslSession.getId();
-
-            StringBuffer buffer = new StringBuffer("SSL session id: ");
-            for (int i = 0; i < bytes.length; i++) {
-                int b = bytes[i] & 0xff;
-                buffer.append(Character.toUpperCase(Character.forDigit((b >> 4) & 0xF, 16)));
-                buffer.append(Character.toUpperCase(Character.forDigit(b & 0xF, 16)));
-            }
-            buffer.append(" for ").append(Thread.currentThread().getName());
-            log.debug(buffer.toString());
-        }
         if (protocolList.length() > 0) {
             try {
                 sock.setEnabledProtocols(protocols);

Modified: jakarta/jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/changes.xml?rev=711582&r1=711581&r2=711582&view=diff
==============================================================================
--- jakarta/jmeter/trunk/xdocs/changes.xml (original)
+++ jakarta/jmeter/trunk/xdocs/changes.xml Wed Nov  5 07:00:31 2008
@@ -144,6 +144,7 @@
 <li>Bug 41608 - misleading warning log message removed</li>
 <li>CSVSaveService - check for EOF while reading quoted string</li>
 <li>Bug 46142 - JMS Receiver now uses MessageID</li>
+<li>Bug 46148 - HTTP sampler fails on SSL requests when logging for jmeter.util is set to DEBUG</li>
 </ul>
 
 <h3>Improvements</h3>



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org