You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by gi...@apache.org on 2026/10/21 09:46:52 UTC
(texera) branch gh-readonly-queue/main/pr-9070-e6e7a6d7d02e50db3710af76b3e9487ee8194227 created (now 9f8727e1f9)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-9070-e6e7a6d7d02e50db3710af76b3e9487ee8194227
in repository https://gitbox.apache.org/repos/asf/texera.git
at 9f8727e1f9 refactor(frontend): remove dataset version creator dead code (#9070)
This branch includes the following new commits:
new 9f8727e1f9 refactor(frontend): remove dataset version creator dead code (#9070)
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(texera) 01/01: refactor(frontend): remove dataset version creator dead code (#9070)
Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-9070-e6e7a6d7d02e50db3710af76b3e9487ee8194227
in repository https://gitbox.apache.org/repos/asf/texera.git
commit 9f8727e1f92383931a887e74c15e472171322163
Author: Xinyuan Lin <xi...@uci.edu>
AuthorDate: Wed Oct 21 07:23:28 2026 +0000
refactor(frontend): remove dataset version creator dead code (#9070)
### What changes were proposed in this PR?
Removes dead code from `UserDatasetVersionCreatorComponent`. **+3/−19
lines.** There is no behaviour change.
- **`isCreateButtonDisabled`:** nothing ever writes it, so it is always
`false`. The create button's `[disabled]="isCreateButtonDisabled ||
isCreating"` becomes `[disabled]="isCreating"`, which evaluates
identically.
- **The `formBuilder` injection:** nothing reads it. `FormBuilder` is
provided in root, so dropping the parameter (and its import) changes
nothing.
- **`.file-uploader` and `.toggle-item .help-text`:** the component uses
emulated encapsulation and no element in its template has either class.
The `files-uploader` child renders its own `.file-uploader`, which this
stylesheet can't reach.
### History
| | |
| --- | --- |
| **Introduced by** | #2413 (2024-02-27), "Introduce Dataset GUI":
`isCreateButtonDisabled`, `formBuilder` and `.file-uploader`. #3663
(2025-08-17), "feat: adding option to allow owner to disallow
downloading datasets": `.help-text` |
| **Usage removed by** | #3296 (2025-03-11), "Add FileService as a
standalone microservice, LakeFS+S3 as dataset storage", removed the
`<div class="file-uploader">` wrapper. `isCreateButtonDisabled`,
`formBuilder` and `.help-text` were **never used** |
`isCreateButtonDisabled` and `formBuilder` have been unused for the two
and a half years since they were added.
### Any related issues, documentation, discussions?
Closes #9067
### How was this PR tested?
No new tests. The component spec's create-button cases still cover the
`[disabled]` binding through `isCreating`.
From `frontend/`:
- `npx ng test --watch=false
--include='**/user-dataset-version-creator.component.spec.ts'
--include='**/user-dataset.component.spec.ts'
--include='**/result-exportation.component.spec.ts'`: 3 files, 105
tests, all pass. The last two specs cover the component's two modal
hosts.
- `yarn format:ci`: clean.
- `npx ng build`: success.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---
.../user-dataset-version-creator.component.html | 2 +-
.../user-dataset-version-creator.component.scss | 13 -------------
.../user-dataset-version-creator.component.ts | 7 ++-----
3 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.html b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.html
index 8320f91772..485db69108 100644
--- a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.html
+++ b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.html
@@ -55,7 +55,7 @@
nz-button
nzType="primary"
(click)="onClickCreate()"
- [disabled]="isCreateButtonDisabled || isCreating"
+ [disabled]="isCreating"
class="create-btn">
Create
</button>
diff --git a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.scss b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.scss
index c6d9dda556..a597dd6dbc 100644
--- a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.scss
+++ b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.scss
@@ -55,12 +55,6 @@
}
}
-.file-uploader {
- height: 40%;
- width: 90%;
- margin: auto;
-}
-
.dataset-toggles {
margin-top: 16px;
margin-bottom: 16px;
@@ -76,11 +70,4 @@
min-width: 80px;
font-weight: 500;
}
-
- .help-text {
- margin-left: 8px;
- font-size: 12px;
- color: #999;
- font-style: italic;
- }
}
diff --git a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.ts b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.ts
index 1eb40dc608..326185d10f 100644
--- a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.ts
+++ b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-version-creator/user-dataset-version-creator.component.ts
@@ -18,7 +18,7 @@
*/
import { Component, inject, OnInit } from "@angular/core";
-import { FormBuilder, FormGroup, FormsModule } from "@angular/forms";
+import { FormGroup, FormsModule } from "@angular/forms";
import { FormlyFieldConfig, FormlyModule } from "@ngx-formly/core";
import { DatasetService } from "../../../../../service/user/dataset/dataset.service";
import { Dataset } from "../../../../../../common/type/dataset";
@@ -58,8 +58,6 @@ export class UserDatasetVersionCreatorComponent implements OnInit {
readonly did: number = inject(NZ_MODAL_DATA)?.did ?? undefined;
- isCreateButtonDisabled: boolean = false;
-
public form: FormGroup = new FormGroup({});
model: any = {};
fields: FormlyFieldConfig[] = [];
@@ -75,8 +73,7 @@ export class UserDatasetVersionCreatorComponent implements OnInit {
constructor(
private modalRef: NzModalRef,
private datasetService: DatasetService,
- private notificationService: NotificationService,
- private formBuilder: FormBuilder
+ private notificationService: NotificationService
) {}
ngOnInit() {