You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2018/12/11 01:56:41 UTC
[GitHub] walhl commented on a change in pull request #381: ProjectL2Cache don't be invalidated when adding override config in cu…
walhl commented on a change in pull request #381: ProjectL2Cache don't be invalidated when adding override config in cu…
URL: https://github.com/apache/kylin/pull/381#discussion_r240449461
##########
File path: core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
##########
@@ -151,11 +151,13 @@ protected CubeInstance initEntityAfterReload(CubeInstance cube, String resourceN
@Override
public void onProjectSchemaChange(Broadcaster broadcaster, String project) throws IOException {
- for (IRealization real : ProjectManager.getInstance(config).listAllRealizations(project)) {
+ ProjectManager projectManager = ProjectManager.getInstance(config);
+ for (IRealization real : projectManager.listAllRealizations(project)) {
if (real instanceof CubeInstance) {
reloadCubeQuietly(real.getName());
}
}
+ projectManager.reloadProjectL2Cache(project);
Review comment:
“onProjectSchemaChange ” method updated all cubeinstance under the given project, but cubeinstances in ProjectL2Cache are not updated. I added reloading "ProjectL2Cache " after updating cubeinstance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services