You are viewing a plain text version of this content. The canonical link for it is here.
Posted to builds@apache.org by Ismael Juma <is...@juma.me.uk> on 2015/07/20 17:15:43 UTC
Triggering CI rebuilds for GitHub pull requests
Hi,
At Kafka, we intend to change our contribution flow to be based on GitHub
pull requests. An important part of this flow is running CI builds on pull
requests. The basics are now working[1] thanks to Andrew Bayer's help. I
have a few questions that I could not find an answer for (if this is
information is already available somewhere, a reference is appreciated) and
I was hoping that someone here could help:
1. Is it possible to trigger a rebuild with "retest this please"?
2. Who is allowed to trigger a rebuild? Is it any committer or only
those with access to Jenkins?
3. Can we use "add to whitelist" to add another user to the authorised
list?
4. Out of curiosity, are we using
https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin
or something custom?
Normally, I would just figure it out by trying these things, but I am not a
committer and I don't have access to Jenkins, which makes things a bit
harder!
Thanks,
Ismael
[1] https://builds.apache.org/job/kafka-trunk-git-pr/
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Andrew Bayer <an...@gmail.com>.
Thanks!
On Wed, Jul 29, 2015 at 12:54 PM, Ismael Juma <is...@juma.me.uk> wrote:
> On Tue, Jul 28, 2015 at 3:01 PM, Andrew Bayer <an...@gmail.com>
> wrote:
>
> > Yes, please. =)
> >
>
> Here it is:
>
> https://issues.apache.org/jira/browse/BUILDS-102
>
> Best,
> Ismael
>
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Ismael Juma <is...@juma.me.uk>.
On Tue, Jul 28, 2015 at 3:01 PM, Andrew Bayer <an...@gmail.com>
wrote:
> Yes, please. =)
>
Here it is:
https://issues.apache.org/jira/browse/BUILDS-102
Best,
Ismael
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Andrew Bayer <an...@gmail.com>.
Yes, please. =)
On Jul 28, 2015 15:53, "Ismael Juma" <is...@juma.me.uk> wrote:
> On Tue, Jul 28, 2015 at 2:14 PM, Andrew Bayer <an...@gmail.com>
> wrote:
>
> > I have not yet - sorry.
> >
>
> Thanks anyway. :) Should I file a JIRA ticket for this feature request?
>
> Ismael
>
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Ismael Juma <is...@juma.me.uk>.
On Tue, Jul 28, 2015 at 2:14 PM, Andrew Bayer <an...@gmail.com>
wrote:
> I have not yet - sorry.
>
Thanks anyway. :) Should I file a JIRA ticket for this feature request?
Ismael
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Andrew Bayer <an...@gmail.com>.
I have not yet - sorry.
A.
On Tue, Jul 28, 2015 at 3:09 PM, Ismael Juma <is...@juma.me.uk> wrote:
> Hi Andrew,
>
> Did you have a chance to look into this? As the number of people using pull
> requests in Kafka increases, it becomes more important to have a solution
> for this. Even if the actual solution may not be available immediately, it
> would still be good to know if there will be one.
>
> Thanks for your help.
>
> Best,
> Ismael
>
> On Thu, Jul 23, 2015 at 10:20 AM, Andrew Bayer <an...@gmail.com>
> wrote:
>
> > I'll find a way. =)
> > On Jul 23, 2015 11:19, "Ismael Juma" <is...@juma.me.uk> wrote:
> >
> > > On Thu, Jul 23, 2015 at 9:36 AM, Andrew Bayer <an...@gmail.com>
> > > wrote:
> > >
> > > > At the time I set us up with the plugin, the OSS one required a lot
> > more
> > > > privileges on the Github side than we are able to give it. I'll check
> > to
> > > > see if it's any more reasonable now. =)
> > > >
> > >
> > > I see, that makes sense. Spark seems to use the open-source plugin with
> > the
> > > AMPLab Jenkins instance:
> > >
> > > https://github.com/apache/spark/pull/7613
> > >
> > >
> >
> https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38199/consoleFull
> > >
> > > Not sure how they do that, but that would imply that there are enough
> > > permissions in the GitHub side (or they're doing something they
> > shouldn't).
> > >
> > > In the context of Kafka, Confluent offered their Jenkins instance, but
> my
> > > preference would be to get it to work with Apache's (if possible).
> > >
> > > Best,
> > > Ismael
> > >
> >
>
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Ismael Juma <is...@juma.me.uk>.
Hi Andrew,
Did you have a chance to look into this? As the number of people using pull
requests in Kafka increases, it becomes more important to have a solution
for this. Even if the actual solution may not be available immediately, it
would still be good to know if there will be one.
Thanks for your help.
Best,
Ismael
On Thu, Jul 23, 2015 at 10:20 AM, Andrew Bayer <an...@gmail.com>
wrote:
> I'll find a way. =)
> On Jul 23, 2015 11:19, "Ismael Juma" <is...@juma.me.uk> wrote:
>
> > On Thu, Jul 23, 2015 at 9:36 AM, Andrew Bayer <an...@gmail.com>
> > wrote:
> >
> > > At the time I set us up with the plugin, the OSS one required a lot
> more
> > > privileges on the Github side than we are able to give it. I'll check
> to
> > > see if it's any more reasonable now. =)
> > >
> >
> > I see, that makes sense. Spark seems to use the open-source plugin with
> the
> > AMPLab Jenkins instance:
> >
> > https://github.com/apache/spark/pull/7613
> >
> >
> https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38199/consoleFull
> >
> > Not sure how they do that, but that would imply that there are enough
> > permissions in the GitHub side (or they're doing something they
> shouldn't).
> >
> > In the context of Kafka, Confluent offered their Jenkins instance, but my
> > preference would be to get it to work with Apache's (if possible).
> >
> > Best,
> > Ismael
> >
>
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Ismael Juma <is...@juma.me.uk>.
On Thu, Jul 23, 2015 at 10:20 AM, Andrew Bayer <an...@gmail.com>
wrote:
> I'll find a way. =)
>
Excellent, thanks. :)
Ismael
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Andrew Bayer <an...@gmail.com>.
I'll find a way. =)
On Jul 23, 2015 11:19, "Ismael Juma" <is...@juma.me.uk> wrote:
> On Thu, Jul 23, 2015 at 9:36 AM, Andrew Bayer <an...@gmail.com>
> wrote:
>
> > At the time I set us up with the plugin, the OSS one required a lot more
> > privileges on the Github side than we are able to give it. I'll check to
> > see if it's any more reasonable now. =)
> >
>
> I see, that makes sense. Spark seems to use the open-source plugin with the
> AMPLab Jenkins instance:
>
> https://github.com/apache/spark/pull/7613
>
> https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38199/consoleFull
>
> Not sure how they do that, but that would imply that there are enough
> permissions in the GitHub side (or they're doing something they shouldn't).
>
> In the context of Kafka, Confluent offered their Jenkins instance, but my
> preference would be to get it to work with Apache's (if possible).
>
> Best,
> Ismael
>
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Ismael Juma <is...@juma.me.uk>.
On Thu, Jul 23, 2015 at 9:36 AM, Andrew Bayer <an...@gmail.com>
wrote:
> At the time I set us up with the plugin, the OSS one required a lot more
> privileges on the Github side than we are able to give it. I'll check to
> see if it's any more reasonable now. =)
>
I see, that makes sense. Spark seems to use the open-source plugin with the
AMPLab Jenkins instance:
https://github.com/apache/spark/pull/7613
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38199/consoleFull
Not sure how they do that, but that would imply that there are enough
permissions in the GitHub side (or they're doing something they shouldn't).
In the context of Kafka, Confluent offered their Jenkins instance, but my
preference would be to get it to work with Apache's (if possible).
Best,
Ismael
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Andrew Bayer <an...@gmail.com>.
At the time I set us up with the plugin, the OSS one required a lot more
privileges on the Github side than we are able to give it. I'll check to
see if it's any more reasonable now. =)
On Jul 23, 2015 10:18, "Ismael Juma" <is...@juma.me.uk> wrote:
> On Wed, Jul 22, 2015 at 5:46 PM, Andrew Bayer <an...@gmail.com>
> wrote:
>
> > I think it only triggers on changes to the pull request - i.e., a new
> > commit. I'll talk to the cloudbees people (we are using the Jenkins
> > Enterprise GH PR plugin, not the open source one) and see if they have
> any
> > ideas.
> >
>
> Thank you Andrew. Hopefully they have some ideas as it's quite important to
> be able to rerun builds (in an ideal there would be no flaky tests,
> but...).
>
> It would be surprising if the enterprise version was unable to do something
> that the open-source version supported from day one.
>
> Best,
> Ismael
>
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Ismael Juma <is...@juma.me.uk>.
On Wed, Jul 22, 2015 at 5:46 PM, Andrew Bayer <an...@gmail.com>
wrote:
> I think it only triggers on changes to the pull request - i.e., a new
> commit. I'll talk to the cloudbees people (we are using the Jenkins
> Enterprise GH PR plugin, not the open source one) and see if they have any
> ideas.
>
Thank you Andrew. Hopefully they have some ideas as it's quite important to
be able to rerun builds (in an ideal there would be no flaky tests, but...).
It would be surprising if the enterprise version was unable to do something
that the open-source version supported from day one.
Best,
Ismael
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Andrew Bayer <an...@gmail.com>.
I think it only triggers on changes to the pull request - i.e., a new
commit. I'll talk to the cloudbees people (we are using the Jenkins
Enterprise GH PR plugin, not the open source one) and see if they have any
ideas.
On Wednesday, July 22, 2015, Ismael Juma <is...@juma.me.uk> wrote:
> Hi,
>
> Any feedback on the below? "retest this please" did not seem to work when a
> committer tried it.
>
> On Mon, Jul 20, 2015 at 4:15 PM, Ismael Juma <ismael@juma.me.uk
> <javascript:;>> wrote:
>
> > Hi,
> >
> > At Kafka, we intend to change our contribution flow to be based on GitHub
> > pull requests. An important part of this flow is running CI builds on
> pull
> > requests. The basics are now working[1] thanks to Andrew Bayer's help. I
> > have a few questions that I could not find an answer for (if this is
> > information is already available somewhere, a reference is appreciated)
> and
> > I was hoping that someone here could help:
> >
> > 1. Is it possible to trigger a rebuild with "retest this please"?
> > 2. Who is allowed to trigger a rebuild? Is it any committer or only
> > those with access to Jenkins?
> > 3. Can we use "add to whitelist" to add another user to the authorised
> > list?
> > 4. Out of curiosity, are we using
> >
> https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin
> > or something custom?
> >
> > Normally, I would just figure it out by trying these things, but I am not
> > a committer and I don't have access to Jenkins, which makes things a bit
> > harder!
> >
> > Thanks,
> > Ismael
> >
> > [1] https://builds.apache.org/job/kafka-trunk-git-pr/
> >
>
Re: Triggering CI rebuilds for GitHub pull requests
Posted by Ismael Juma <is...@juma.me.uk>.
Hi,
Any feedback on the below? "retest this please" did not seem to work when a
committer tried it.
On Mon, Jul 20, 2015 at 4:15 PM, Ismael Juma <is...@juma.me.uk> wrote:
> Hi,
>
> At Kafka, we intend to change our contribution flow to be based on GitHub
> pull requests. An important part of this flow is running CI builds on pull
> requests. The basics are now working[1] thanks to Andrew Bayer's help. I
> have a few questions that I could not find an answer for (if this is
> information is already available somewhere, a reference is appreciated) and
> I was hoping that someone here could help:
>
> 1. Is it possible to trigger a rebuild with "retest this please"?
> 2. Who is allowed to trigger a rebuild? Is it any committer or only
> those with access to Jenkins?
> 3. Can we use "add to whitelist" to add another user to the authorised
> list?
> 4. Out of curiosity, are we using
> https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin
> or something custom?
>
> Normally, I would just figure it out by trying these things, but I am not
> a committer and I don't have access to Jenkins, which makes things a bit
> harder!
>
> Thanks,
> Ismael
>
> [1] https://builds.apache.org/job/kafka-trunk-git-pr/
>