[GitHub] [pulsar] eolivelli commented on a change in pull request #10312: Fix the inconsistency of AdvertisedAddress

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #10312:
URL: https://github.com/apache/pulsar/pull/10312#discussion_r618084728



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -271,22 +270,10 @@ public PulsarService(ServiceConfiguration config,
         // Validate correctness of configuration
         PulsarConfigurationLoader.isComplete(config);
         // validate `advertisedAddress`, `advertisedListeners`, `internalListenerName`
-        Map<String, AdvertisedListener> result =
-                MultipleListenerValidator.validateAndAnalysisAdvertisedListener(config);
-        if (result != null) {
-            this.advertisedListeners = Collections.unmodifiableMap(result);
-        } else {
-            this.advertisedListeners = Collections.unmodifiableMap(Collections.emptyMap());

Review comment:
       It looks to me that now we are no more assigning a value to this field.
   Should we remove it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org