[jira] Updated: (SOLR-2320) ReplicationHandler doesn't return master details unless it's also configured as a slave

["Hoss Man (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-2320:
---------------------------

    Attachment: SOLR-2320.patch

simple patch moving the code for adding the details out of the nested conditional.

hoping someone who understands replication better then me can sanity check this.



> ReplicationHandler doesn't return master details unless it's also configured as a slave
> ---------------------------------------------------------------------------------------
>
>                 Key: SOLR-2320
>                 URL: https://issues.apache.org/jira/browse/SOLR-2320
>             Project: Solr
>          Issue Type: Bug
>          Components: replication (java)
>    Affects Versions: 1.4, 1.4.1
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2320.patch
>
>
> While investigating SOLR-2314 i found a bug which seems to be the opposite of the behavior described there -- so i'm filing a seperate bug to track it.
> if ReplicationHandler is only configured as a master, "command=details" requests won't include the "master" section.  that section is only output if it is also configured as a slave.
> the method responsible for the details command generates the "master" details just fine, but the code to add it to the response seems to have erroneously been nested inside an if that only evaluates to true if there is a non-null SnapPuller (ie: it's also a slave)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org