[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted.

[GitBox <gi...@apache.org>]

thomaswoeckinger commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted.
URL: https://github.com/apache/lucene-solr/pull/902#discussion_r329306209
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/schema/SchemaManager.java
 ##########
 @@ -138,6 +138,7 @@ private List doOperations(List<CommandOperation> operations) throws InterruptedE
             //only for non cloud stuff
             managedIndexSchema.persistManagedSchema(false);
             core.setLatestSchema(managedIndexSchema);
+            core.getCoreContainer().reload(core.getName());
 
 Review comment:
   I fave 2 test failing, which behave different when running with ant or in eclipse:
   
   org.apache.solr.rest.schema.TestBulkSchemaAPI.testAnalyzerClass()
   org.apache.solr.client.solrj.request.SchemaTest.addFieldTypeWithAnalyzerClassAccuracy()
   
   Both are failing because luceneMatchVersion attribute of the analyzer configuration does not match, when running with ant it is always the latest version, in eclipse null is returned.
   
   I am not sure what is the expected result when setting luceneMatchVersion on an analyzer.
   
   Found additional NullPointer issues in some Schema test which are not related to the change but to the execution order of tests, fixed them to.
   
   I pushed the changes, waiting for your feedback.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org