You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/02/24 10:07:46 UTC
[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #8503: [Feature-8485][task-plugin] add EMR task plugin to support submit task to AWS EMR
caishunfeng commented on a change in pull request #8503:
URL: https://github.com/apache/dolphinscheduler/pull/8503#discussion_r813720756
##########
File path: dolphinscheduler-task-plugin/dolphinscheduler-task-emr/src/main/java/org/apache/dolphinscheduler/plugin/task/emr/EmrTask.java
##########
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.task.emr;
+
+import static com.fasterxml.jackson.databind.DeserializationFeature.ACCEPT_EMPTY_ARRAY_AS_NULL_OBJECT;
+import static com.fasterxml.jackson.databind.DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES;
+import static com.fasterxml.jackson.databind.DeserializationFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL;
+import static com.fasterxml.jackson.databind.MapperFeature.REQUIRE_SETTERS_FOR_GETTERS;
+
+import org.apache.dolphinscheduler.plugin.task.api.AbstractTaskExecutor;
+import org.apache.dolphinscheduler.spi.task.AbstractParameters;
+import org.apache.dolphinscheduler.spi.task.TaskConstants;
+import org.apache.dolphinscheduler.spi.task.request.TaskRequest;
+import org.apache.dolphinscheduler.spi.utils.JSONUtils;
+import org.apache.dolphinscheduler.spi.utils.PropertyUtils;
+
+import java.util.HashSet;
+import java.util.TimeZone;
+import java.util.concurrent.TimeUnit;
+
+import com.amazonaws.SdkBaseException;
+import com.amazonaws.auth.AWSCredentialsProvider;
+import com.amazonaws.auth.AWSStaticCredentialsProvider;
+import com.amazonaws.auth.BasicAWSCredentials;
+import com.amazonaws.services.elasticmapreduce.AmazonElasticMapReduce;
+import com.amazonaws.services.elasticmapreduce.AmazonElasticMapReduceClientBuilder;
+import com.amazonaws.services.elasticmapreduce.model.ClusterState;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStateChangeReason;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStateChangeReasonCode;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStatus;
+import com.amazonaws.services.elasticmapreduce.model.DescribeClusterRequest;
+import com.amazonaws.services.elasticmapreduce.model.DescribeClusterResult;
+import com.amazonaws.services.elasticmapreduce.model.RunJobFlowRequest;
+import com.amazonaws.services.elasticmapreduce.model.RunJobFlowResult;
+import com.amazonaws.services.elasticmapreduce.model.TerminateJobFlowsRequest;
+import com.amazonaws.services.elasticmapreduce.model.TerminateJobFlowsResult;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.PropertyNamingStrategy;
+import com.fasterxml.jackson.databind.cfg.MapperConfig;
+import com.fasterxml.jackson.databind.introspect.AnnotatedMethod;
+import com.google.common.collect.Sets;
+
+public class EmrTask extends AbstractTaskExecutor {
+
+ /**
+ * taskExecutionContext
+ */
+ private final TaskRequest taskExecutionContext;
+ /**
+ * emr parameters
+ */
+ private EmrParameters emrParameters;
+ private AmazonElasticMapReduce emrClient;
+
+ private String clusterId;
+
+ private final HashSet<String> waitingStateSet = Sets.newHashSet(
+ ClusterState.STARTING.toString(),
+ ClusterState.BOOTSTRAPPING.toString(),
+ ClusterState.RUNNING.toString()
+ );
+
+ /**
+ * config ObjectMapper features and propertyNamingStrategy
+ * support capital letters parse
+ */
+ private static final ObjectMapper objectMapper = new ObjectMapper()
+ .configure(FAIL_ON_UNKNOWN_PROPERTIES, false)
+ .configure(ACCEPT_EMPTY_ARRAY_AS_NULL_OBJECT, true)
+ .configure(READ_UNKNOWN_ENUM_VALUES_AS_NULL, true)
+ .configure(REQUIRE_SETTERS_FOR_GETTERS, true)
+ .setPropertyNamingStrategy(new PropertyNamingStrategy() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public String nameForSetterMethod(MapperConfig<?> config,
+ AnnotatedMethod method, String defaultName) {
+ return method.getName().substring(3);
+ }
+
+ @Override
+ public String nameForGetterMethod(MapperConfig<?> config,
+ AnnotatedMethod method, String defaultName) {
+ return method.getName().substring(3);
+ }
+ }).setTimeZone(TimeZone.getDefault());
+
+ /**
+ * constructor
+ *
+ * @param taskExecutionContext taskExecutionContext
+ */
+ protected EmrTask(TaskRequest taskExecutionContext) {
+
+ super(taskExecutionContext);
+ this.taskExecutionContext = taskExecutionContext;
+
+ }
+
+ @Override
+ public void init() {
+ logger.info("emr task params:{}", taskExecutionContext.getTaskParams());
+ emrParameters = JSONUtils.parseObject(taskExecutionContext.getTaskParams(), EmrParameters.class);
+ if (emrParameters == null || !emrParameters.checkParameters()) {
+ throw new EmrTaskException("emr task params is not valid");
+ }
+ emrClient = createEmrClient();
+ }
+
+ @Override
+ public void handle() throws InterruptedException {
+ ClusterStatus clusterStatus = null;
+ try {
+ RunJobFlowRequest runJobFlowRequest = createRunJobFlowRequest();
+
+ // submit runJobFlowRequest to aws
+ RunJobFlowResult result = emrClient.runJobFlow(runJobFlowRequest);
+
+ clusterId = result.getJobFlowId();
Review comment:
Should it recode the jobFlowId as appId?
##########
File path: dolphinscheduler-task-plugin/dolphinscheduler-task-emr/src/main/java/org/apache/dolphinscheduler/plugin/task/emr/EmrTask.java
##########
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.task.emr;
+
+import static com.fasterxml.jackson.databind.DeserializationFeature.ACCEPT_EMPTY_ARRAY_AS_NULL_OBJECT;
+import static com.fasterxml.jackson.databind.DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES;
+import static com.fasterxml.jackson.databind.DeserializationFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL;
+import static com.fasterxml.jackson.databind.MapperFeature.REQUIRE_SETTERS_FOR_GETTERS;
+
+import org.apache.dolphinscheduler.plugin.task.api.AbstractTaskExecutor;
+import org.apache.dolphinscheduler.spi.task.AbstractParameters;
+import org.apache.dolphinscheduler.spi.task.TaskConstants;
+import org.apache.dolphinscheduler.spi.task.request.TaskRequest;
+import org.apache.dolphinscheduler.spi.utils.JSONUtils;
+import org.apache.dolphinscheduler.spi.utils.PropertyUtils;
+
+import java.util.HashSet;
+import java.util.TimeZone;
+import java.util.concurrent.TimeUnit;
+
+import com.amazonaws.SdkBaseException;
+import com.amazonaws.auth.AWSCredentialsProvider;
+import com.amazonaws.auth.AWSStaticCredentialsProvider;
+import com.amazonaws.auth.BasicAWSCredentials;
+import com.amazonaws.services.elasticmapreduce.AmazonElasticMapReduce;
+import com.amazonaws.services.elasticmapreduce.AmazonElasticMapReduceClientBuilder;
+import com.amazonaws.services.elasticmapreduce.model.ClusterState;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStateChangeReason;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStateChangeReasonCode;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStatus;
+import com.amazonaws.services.elasticmapreduce.model.DescribeClusterRequest;
+import com.amazonaws.services.elasticmapreduce.model.DescribeClusterResult;
+import com.amazonaws.services.elasticmapreduce.model.RunJobFlowRequest;
+import com.amazonaws.services.elasticmapreduce.model.RunJobFlowResult;
+import com.amazonaws.services.elasticmapreduce.model.TerminateJobFlowsRequest;
+import com.amazonaws.services.elasticmapreduce.model.TerminateJobFlowsResult;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.PropertyNamingStrategy;
+import com.fasterxml.jackson.databind.cfg.MapperConfig;
+import com.fasterxml.jackson.databind.introspect.AnnotatedMethod;
+import com.google.common.collect.Sets;
+
+public class EmrTask extends AbstractTaskExecutor {
+
+ /**
+ * taskExecutionContext
+ */
+ private final TaskRequest taskExecutionContext;
+ /**
+ * emr parameters
+ */
+ private EmrParameters emrParameters;
+ private AmazonElasticMapReduce emrClient;
+
+ private String clusterId;
+
+ private final HashSet<String> waitingStateSet = Sets.newHashSet(
+ ClusterState.STARTING.toString(),
+ ClusterState.BOOTSTRAPPING.toString(),
+ ClusterState.RUNNING.toString()
+ );
+
+ /**
+ * config ObjectMapper features and propertyNamingStrategy
+ * support capital letters parse
+ */
+ private static final ObjectMapper objectMapper = new ObjectMapper()
+ .configure(FAIL_ON_UNKNOWN_PROPERTIES, false)
+ .configure(ACCEPT_EMPTY_ARRAY_AS_NULL_OBJECT, true)
+ .configure(READ_UNKNOWN_ENUM_VALUES_AS_NULL, true)
+ .configure(REQUIRE_SETTERS_FOR_GETTERS, true)
+ .setPropertyNamingStrategy(new PropertyNamingStrategy() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public String nameForSetterMethod(MapperConfig<?> config,
+ AnnotatedMethod method, String defaultName) {
+ return method.getName().substring(3);
Review comment:
Why use `substring(3)` here? Can you add some comment for it?
##########
File path: dolphinscheduler-task-plugin/dolphinscheduler-task-emr/src/main/java/org/apache/dolphinscheduler/plugin/task/emr/EmrTask.java
##########
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.task.emr;
+
+import static com.fasterxml.jackson.databind.DeserializationFeature.ACCEPT_EMPTY_ARRAY_AS_NULL_OBJECT;
+import static com.fasterxml.jackson.databind.DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES;
+import static com.fasterxml.jackson.databind.DeserializationFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL;
+import static com.fasterxml.jackson.databind.MapperFeature.REQUIRE_SETTERS_FOR_GETTERS;
+
+import org.apache.dolphinscheduler.plugin.task.api.AbstractTaskExecutor;
+import org.apache.dolphinscheduler.spi.task.AbstractParameters;
+import org.apache.dolphinscheduler.spi.task.TaskConstants;
+import org.apache.dolphinscheduler.spi.task.request.TaskRequest;
+import org.apache.dolphinscheduler.spi.utils.JSONUtils;
+import org.apache.dolphinscheduler.spi.utils.PropertyUtils;
+
+import java.util.HashSet;
+import java.util.TimeZone;
+import java.util.concurrent.TimeUnit;
+
+import com.amazonaws.SdkBaseException;
+import com.amazonaws.auth.AWSCredentialsProvider;
+import com.amazonaws.auth.AWSStaticCredentialsProvider;
+import com.amazonaws.auth.BasicAWSCredentials;
+import com.amazonaws.services.elasticmapreduce.AmazonElasticMapReduce;
+import com.amazonaws.services.elasticmapreduce.AmazonElasticMapReduceClientBuilder;
+import com.amazonaws.services.elasticmapreduce.model.ClusterState;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStateChangeReason;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStateChangeReasonCode;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStatus;
+import com.amazonaws.services.elasticmapreduce.model.DescribeClusterRequest;
+import com.amazonaws.services.elasticmapreduce.model.DescribeClusterResult;
+import com.amazonaws.services.elasticmapreduce.model.RunJobFlowRequest;
+import com.amazonaws.services.elasticmapreduce.model.RunJobFlowResult;
+import com.amazonaws.services.elasticmapreduce.model.TerminateJobFlowsRequest;
+import com.amazonaws.services.elasticmapreduce.model.TerminateJobFlowsResult;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.PropertyNamingStrategy;
+import com.fasterxml.jackson.databind.cfg.MapperConfig;
+import com.fasterxml.jackson.databind.introspect.AnnotatedMethod;
+import com.google.common.collect.Sets;
+
+public class EmrTask extends AbstractTaskExecutor {
+
+ /**
+ * taskExecutionContext
+ */
+ private final TaskRequest taskExecutionContext;
+ /**
+ * emr parameters
+ */
+ private EmrParameters emrParameters;
+ private AmazonElasticMapReduce emrClient;
+
+ private String clusterId;
+
+ private final HashSet<String> waitingStateSet = Sets.newHashSet(
+ ClusterState.STARTING.toString(),
+ ClusterState.BOOTSTRAPPING.toString(),
+ ClusterState.RUNNING.toString()
+ );
+
+ /**
+ * config ObjectMapper features and propertyNamingStrategy
+ * support capital letters parse
+ */
+ private static final ObjectMapper objectMapper = new ObjectMapper()
+ .configure(FAIL_ON_UNKNOWN_PROPERTIES, false)
+ .configure(ACCEPT_EMPTY_ARRAY_AS_NULL_OBJECT, true)
+ .configure(READ_UNKNOWN_ENUM_VALUES_AS_NULL, true)
+ .configure(REQUIRE_SETTERS_FOR_GETTERS, true)
+ .setPropertyNamingStrategy(new PropertyNamingStrategy() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public String nameForSetterMethod(MapperConfig<?> config,
+ AnnotatedMethod method, String defaultName) {
+ return method.getName().substring(3);
+ }
+
+ @Override
+ public String nameForGetterMethod(MapperConfig<?> config,
+ AnnotatedMethod method, String defaultName) {
+ return method.getName().substring(3);
+ }
+ }).setTimeZone(TimeZone.getDefault());
+
+ /**
+ * constructor
+ *
+ * @param taskExecutionContext taskExecutionContext
+ */
+ protected EmrTask(TaskRequest taskExecutionContext) {
+
+ super(taskExecutionContext);
+ this.taskExecutionContext = taskExecutionContext;
+
+ }
+
+ @Override
+ public void init() {
+ logger.info("emr task params:{}", taskExecutionContext.getTaskParams());
+ emrParameters = JSONUtils.parseObject(taskExecutionContext.getTaskParams(), EmrParameters.class);
+ if (emrParameters == null || !emrParameters.checkParameters()) {
+ throw new EmrTaskException("emr task params is not valid");
+ }
+ emrClient = createEmrClient();
+ }
+
+ @Override
+ public void handle() throws InterruptedException {
+ ClusterStatus clusterStatus = null;
+ try {
+ RunJobFlowRequest runJobFlowRequest = createRunJobFlowRequest();
+
+ // submit runJobFlowRequest to aws
+ RunJobFlowResult result = emrClient.runJobFlow(runJobFlowRequest);
+
+ clusterId = result.getJobFlowId();
+
+ clusterStatus = getClusterStatus();
+
+ while (waitingStateSet.contains(clusterStatus.getState())) {
+ TimeUnit.SECONDS.sleep(10);
+ clusterStatus = getClusterStatus();
+ }
+
+ } catch (EmrTaskException | SdkBaseException e) {
+ logger.error("emr task submit failed with error", e);
+ setExitStatusCode(TaskConstants.EXIT_CODE_FAILURE);
+ } finally {
+ if (clusterStatus != null) {
+ calculateExitStatusCode(clusterStatus);
+ logger.info("emr task finished with cluster status : {}", clusterStatus);
+ }
+ }
+ }
+
+ /**
+ * parse json string to RunJobFlowRequest
+ *
+ * @return RunJobFlowRequest
+ */
+ private RunJobFlowRequest createRunJobFlowRequest() {
+
+ final RunJobFlowRequest runJobFlowRequest;
+ try {
+ runJobFlowRequest = objectMapper.readValue(emrParameters.getJobFlowDefineJson(), RunJobFlowRequest.class);
+ } catch (JsonProcessingException e) {
+ throw new EmrTaskException("can not parse RunJobFlowRequest from json", e);
+ }
+
+ return runJobFlowRequest;
+ }
+
+ /**
+ * calculate task exitStatusCode
+ *
+ * @param clusterStatus aws emr cluster status
+ */
+ private void calculateExitStatusCode(ClusterStatus clusterStatus) {
+ String state = clusterStatus.getState();
+ ClusterStateChangeReason stateChangeReason = clusterStatus.getStateChangeReason();
+ ClusterState clusterState = ClusterState.valueOf(state);
+ int exitStatusCode;
+ switch (clusterState) {
+ case TERMINATED:
+ case TERMINATING:
+ String code = stateChangeReason.getCode();
+ if (code != null && code.equalsIgnoreCase(ClusterStateChangeReasonCode.ALL_STEPS_COMPLETED.toString())) {
+ exitStatusCode = TaskConstants.EXIT_CODE_SUCCESS;
+ } else {
+ exitStatusCode = TaskConstants.EXIT_CODE_KILL;
+ }
+ break;
+ case TERMINATED_WITH_ERRORS:
+ exitStatusCode = TaskConstants.EXIT_CODE_FAILURE;
+ break;
+ default:
+ exitStatusCode = TaskConstants.EXIT_CODE_SUCCESS;
+ break;
+ }
+ setExitStatusCode(exitStatusCode);
+ }
+
+ private ClusterStatus getClusterStatus() {
+ DescribeClusterRequest describeClusterRequest = new DescribeClusterRequest().withClusterId(clusterId);
+ DescribeClusterResult result = emrClient.describeCluster(describeClusterRequest);
+ if (result == null) {
+ throw new EmrTaskException("fetch cluster status failed");
+ }
+ ClusterStatus clusterStatus = result.getCluster().getStatus();
+ logger.info("emr cluster [clusterId:{}] running with status:{}", clusterId, clusterStatus);
+ return clusterStatus;
+
+ }
+
+ @Override
+ public AbstractParameters getParameters() {
+ return emrParameters;
+ }
+
+ /**
+ * create emr client from aws named profiles file
+ *
+ * @return AmazonElasticMapReduce
+ */
+ private AmazonElasticMapReduce createEmrClient() {
+
+ final String awsAccessKeyId = PropertyUtils.getString(TaskConstants.AWS_ACCESS_KEY_ID);
+ final String awsSecretAccessKey = PropertyUtils.getString(TaskConstants.AWS_SECRET_ACCESS_KEY);
+ final String awsRegion = PropertyUtils.getString(TaskConstants.AWS_REGION);
+ final BasicAWSCredentials basicAWSCredentials = new BasicAWSCredentials(awsAccessKeyId, awsSecretAccessKey);
+ final AWSCredentialsProvider awsCredentialsProvider = new AWSStaticCredentialsProvider(basicAWSCredentials);
+ // create an EMR client
+ return AmazonElasticMapReduceClientBuilder.standard()
+ .withCredentials(awsCredentialsProvider)
+ .withRegion(awsRegion)
+ .build();
+ }
+
+ @Override
+ public void cancelApplication(boolean status) throws Exception {
+ super.cancelApplication(status);
+
+ logger.info("trying terminate job flow ");
Review comment:
```suggestion
logger.info("trying terminate job flow, taskId:{}, clusterId:{}", taskId, clusterId);
```
##########
File path: dolphinscheduler-task-plugin/dolphinscheduler-task-emr/src/main/java/org/apache/dolphinscheduler/plugin/task/emr/EmrTask.java
##########
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.task.emr;
+
+import static com.fasterxml.jackson.databind.DeserializationFeature.ACCEPT_EMPTY_ARRAY_AS_NULL_OBJECT;
+import static com.fasterxml.jackson.databind.DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES;
+import static com.fasterxml.jackson.databind.DeserializationFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL;
+import static com.fasterxml.jackson.databind.MapperFeature.REQUIRE_SETTERS_FOR_GETTERS;
+
+import org.apache.dolphinscheduler.plugin.task.api.AbstractTaskExecutor;
+import org.apache.dolphinscheduler.spi.task.AbstractParameters;
+import org.apache.dolphinscheduler.spi.task.TaskConstants;
+import org.apache.dolphinscheduler.spi.task.request.TaskRequest;
+import org.apache.dolphinscheduler.spi.utils.JSONUtils;
+import org.apache.dolphinscheduler.spi.utils.PropertyUtils;
+
+import java.util.HashSet;
+import java.util.TimeZone;
+import java.util.concurrent.TimeUnit;
+
+import com.amazonaws.SdkBaseException;
+import com.amazonaws.auth.AWSCredentialsProvider;
+import com.amazonaws.auth.AWSStaticCredentialsProvider;
+import com.amazonaws.auth.BasicAWSCredentials;
+import com.amazonaws.services.elasticmapreduce.AmazonElasticMapReduce;
+import com.amazonaws.services.elasticmapreduce.AmazonElasticMapReduceClientBuilder;
+import com.amazonaws.services.elasticmapreduce.model.ClusterState;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStateChangeReason;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStateChangeReasonCode;
+import com.amazonaws.services.elasticmapreduce.model.ClusterStatus;
+import com.amazonaws.services.elasticmapreduce.model.DescribeClusterRequest;
+import com.amazonaws.services.elasticmapreduce.model.DescribeClusterResult;
+import com.amazonaws.services.elasticmapreduce.model.RunJobFlowRequest;
+import com.amazonaws.services.elasticmapreduce.model.RunJobFlowResult;
+import com.amazonaws.services.elasticmapreduce.model.TerminateJobFlowsRequest;
+import com.amazonaws.services.elasticmapreduce.model.TerminateJobFlowsResult;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.PropertyNamingStrategy;
+import com.fasterxml.jackson.databind.cfg.MapperConfig;
+import com.fasterxml.jackson.databind.introspect.AnnotatedMethod;
+import com.google.common.collect.Sets;
+
+public class EmrTask extends AbstractTaskExecutor {
+
+ /**
+ * taskExecutionContext
+ */
+ private final TaskRequest taskExecutionContext;
+ /**
+ * emr parameters
+ */
+ private EmrParameters emrParameters;
+ private AmazonElasticMapReduce emrClient;
+
+ private String clusterId;
+
+ private final HashSet<String> waitingStateSet = Sets.newHashSet(
+ ClusterState.STARTING.toString(),
+ ClusterState.BOOTSTRAPPING.toString(),
+ ClusterState.RUNNING.toString()
+ );
+
+ /**
+ * config ObjectMapper features and propertyNamingStrategy
+ * support capital letters parse
+ */
+ private static final ObjectMapper objectMapper = new ObjectMapper()
+ .configure(FAIL_ON_UNKNOWN_PROPERTIES, false)
+ .configure(ACCEPT_EMPTY_ARRAY_AS_NULL_OBJECT, true)
+ .configure(READ_UNKNOWN_ENUM_VALUES_AS_NULL, true)
+ .configure(REQUIRE_SETTERS_FOR_GETTERS, true)
+ .setPropertyNamingStrategy(new PropertyNamingStrategy() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public String nameForSetterMethod(MapperConfig<?> config,
+ AnnotatedMethod method, String defaultName) {
+ return method.getName().substring(3);
+ }
+
+ @Override
+ public String nameForGetterMethod(MapperConfig<?> config,
+ AnnotatedMethod method, String defaultName) {
+ return method.getName().substring(3);
+ }
+ }).setTimeZone(TimeZone.getDefault());
+
+ /**
+ * constructor
+ *
+ * @param taskExecutionContext taskExecutionContext
+ */
+ protected EmrTask(TaskRequest taskExecutionContext) {
+
+ super(taskExecutionContext);
+ this.taskExecutionContext = taskExecutionContext;
+
+ }
+
+ @Override
+ public void init() {
+ logger.info("emr task params:{}", taskExecutionContext.getTaskParams());
+ emrParameters = JSONUtils.parseObject(taskExecutionContext.getTaskParams(), EmrParameters.class);
+ if (emrParameters == null || !emrParameters.checkParameters()) {
+ throw new EmrTaskException("emr task params is not valid");
+ }
+ emrClient = createEmrClient();
+ }
+
+ @Override
+ public void handle() throws InterruptedException {
+ ClusterStatus clusterStatus = null;
+ try {
+ RunJobFlowRequest runJobFlowRequest = createRunJobFlowRequest();
+
+ // submit runJobFlowRequest to aws
+ RunJobFlowResult result = emrClient.runJobFlow(runJobFlowRequest);
+
+ clusterId = result.getJobFlowId();
+
+ clusterStatus = getClusterStatus();
+
+ while (waitingStateSet.contains(clusterStatus.getState())) {
+ TimeUnit.SECONDS.sleep(10);
+ clusterStatus = getClusterStatus();
+ }
+
+ } catch (EmrTaskException | SdkBaseException e) {
+ logger.error("emr task submit failed with error", e);
+ setExitStatusCode(TaskConstants.EXIT_CODE_FAILURE);
+ } finally {
+ if (clusterStatus != null) {
+ calculateExitStatusCode(clusterStatus);
+ logger.info("emr task finished with cluster status : {}", clusterStatus);
+ }
+ }
+ }
+
+ /**
+ * parse json string to RunJobFlowRequest
+ *
+ * @return RunJobFlowRequest
+ */
+ private RunJobFlowRequest createRunJobFlowRequest() {
+
+ final RunJobFlowRequest runJobFlowRequest;
+ try {
+ runJobFlowRequest = objectMapper.readValue(emrParameters.getJobFlowDefineJson(), RunJobFlowRequest.class);
+ } catch (JsonProcessingException e) {
+ throw new EmrTaskException("can not parse RunJobFlowRequest from json", e);
+ }
+
+ return runJobFlowRequest;
+ }
+
+ /**
+ * calculate task exitStatusCode
+ *
+ * @param clusterStatus aws emr cluster status
+ */
+ private void calculateExitStatusCode(ClusterStatus clusterStatus) {
+ String state = clusterStatus.getState();
+ ClusterStateChangeReason stateChangeReason = clusterStatus.getStateChangeReason();
+ ClusterState clusterState = ClusterState.valueOf(state);
+ int exitStatusCode;
+ switch (clusterState) {
+ case TERMINATED:
+ case TERMINATING:
+ String code = stateChangeReason.getCode();
+ if (code != null && code.equalsIgnoreCase(ClusterStateChangeReasonCode.ALL_STEPS_COMPLETED.toString())) {
+ exitStatusCode = TaskConstants.EXIT_CODE_SUCCESS;
+ } else {
+ exitStatusCode = TaskConstants.EXIT_CODE_KILL;
+ }
+ break;
+ case TERMINATED_WITH_ERRORS:
+ exitStatusCode = TaskConstants.EXIT_CODE_FAILURE;
+ break;
+ default:
+ exitStatusCode = TaskConstants.EXIT_CODE_SUCCESS;
Review comment:
Is it OK of default success? If other state add in the future, it will be wrong. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org