You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/29 12:18:29 UTC

[GitHub] [dubbo-go] louyuting opened a new pull request #821: fix sentinel windows issue

louyuting opened a new pull request #821:
URL: https://github.com/apache/dubbo-go/pull/821


   **What this PR does**:
   Upgrade sentinel go to v0.6.2 to degrade system module in windows OS
   
   **Which issue(s) this PR fixes**:
   None
   
   **Special notes for your reviewer**:
   @AlexStocks 
   
   **Does this PR introduce a user-facing change?**:
   
   ```release-note
   Upgrade sentinel go to v0.6.2 to degrade system module in windows OS
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] Patrick0308 merged pull request #821: fix sentinel windows issue

Posted by GitBox <gi...@apache.org>.
Patrick0308 merged pull request #821:
URL: https://github.com/apache/dubbo-go/pull/821


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] codecov-io commented on pull request #821: fix sentinel windows issue

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #821:
URL: https://github.com/apache/dubbo-go/pull/821#issuecomment-718720223


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/821?src=pr&el=h1) Report
   > Merging [#821](https://codecov.io/gh/apache/dubbo-go/pull/821?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/0384e201ecac8a1a76659b5dbf5f9f07edf41533?el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/821/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/821?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #821      +/-   ##
   ===========================================
   - Coverage    59.84%   59.77%   -0.07%     
   ===========================================
     Files          260      260              
     Lines        12762    12762              
   ===========================================
   - Hits          7637     7629       -8     
   - Misses        4169     4177       +8     
     Partials       956      956              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/821?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/821/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `52.17% <0.00%> (-8.70%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/821?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/821?src=pr&el=footer). Last update [0384e20...a548cc4](https://codecov.io/gh/apache/dubbo-go/pull/821?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org