You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/08/06 21:40:05 UTC
Re: [PR] fix: handle formatter errors gracefully in table cell rendering (#36189) [superset]
rusackas commented on PR #39658:
URL: https://github.com/apache/superset/pull/39658#issuecomment-5209301607
Nice fix for the crash, but the `CurrencyFormatter` branch just above stays unguarded — an AUTO-mode currency formatter can throw too. Worth wrapping that call in the same try/catch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org