You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2025/01/28 12:36:30 UTC
[PR] feat(components): add camel-telemetry component [camel]
squakez opened a new pull request, #16949:
URL: https://github.com/apache/camel/pull/16949
First implementation of the camel-telemetry abstract component as described in CAMEL-21670 - longer term goal will be to replace the actual camel-tracing with this one instead.
NOTE: this is a draft to collect early feedback. The final work is planned for release 4.11.0 version.
Scope of the work:
* Based on camel-tracing
* Abstract development as provided in the design document
* Include "enableProcessors" feature as provided in camel-opentelemetry
* Wide range of unit test to cover the main use cases
* Inmemory implementation of a mock Tracer which is service to test the logic without needing a concrete implementation
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(components): add camel-telemetry component [camel]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #16949:
URL: https://github.com/apache/camel/pull/16949#issuecomment-2618888222
@davsclaus @oscerd FYI, as it's a new component can you verify all poms are okey? I think to recall something else from catalog side may be needed, please, advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(components): add camel-telemetry component [camel]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #16949:
URL: https://github.com/apache/camel/pull/16949#issuecomment-2619115991
Okey, then, I'll wait for a review on the logic of the component. I will keep this on hold at least until 4.10 is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(components): add camel-telemetry component [camel]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #16949:
URL: https://github.com/apache/camel/pull/16949#issuecomment-2653138624
Blocked by https://github.com/netplex/json-smart-v2/issues/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(components): add camel-telemetry component [camel]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #16949:
URL: https://github.com/apache/camel/pull/16949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(components): add camel-telemetry component [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16949:
URL: https://github.com/apache/camel/pull/16949#issuecomment-2618885429
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(components): add camel-telemetry component [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #16949:
URL: https://github.com/apache/camel/pull/16949#issuecomment-2619032157
At first glance it looks correct - this is added to catalog as `other` and also added to the nav in the docs etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(components): add camel-telemetry component [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #16949:
URL: https://github.com/apache/camel/pull/16949#issuecomment-2619082684
Seems good. Everything in order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org