You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Drew Johnson <dr...@camelini.com> on 2011/03/03 17:44:11 UTC

Postage with James v3 trunk

I made a couple of small changes to postage in order to get it working with
the v3 server trunk. Is there value/interest in getting a postage trunk that
is working with the v3 server trunk.

- Drew

Re: Refactoring regardless IMAP-258

Posted by Norman Maurer <no...@apache.org>.
Well I think if we really want to keep the method we should at least reuse
the method with the callback under the hood. So we don't need to keep all
the code duplicated.

Bye,
Norman


2011/3/3 Wojciech Strzałka <ws...@gmail.com>

>  Hi
>
>    Regardless the removing old method from MessageManager:
>
>    Iterator<MessageResult> getMessages(MessageRange set, FetchGroup
>    fetchGroup, MailboxSession mailboxSession) throws MailboxException;
>
>    I'd started refactoring and I think removing this method will
>    cause code complication in several places that don't use batching
>    - especially in the places where single record is fetched.
>
>    If leaving the method would get acceptance I think it should also
>    be changed to modify MessageRange the way result is not returned
>    in batched in fact (then it's consolidated anyway so batching in
>    such a case makes no sense).
>
>
>    WDYT ?
>
>
>

Refactoring regardless IMAP-258

Posted by Wojciech Strzałka <ws...@gmail.com>.
  Hi

    Regardless the removing old method from MessageManager:

    Iterator<MessageResult> getMessages(MessageRange set, FetchGroup
    fetchGroup, MailboxSession mailboxSession) throws MailboxException;

    I'd started refactoring and I think removing this method will
    cause code complication in several places that don't use batching
    - especially in the places where single record is fetched.

    If leaving the method would get acceptance I think it should also
    be changed to modify MessageRange the way result is not returned
    in batched in fact (then it's consolidated anyway so batching in
    such a case makes no sense).


    WDYT ?
    


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: Postage with James v3 trunk

Posted by Norman Maurer <no...@apache.org>.
Sure...

please create a patch and attach it to jira.

Thanks,
Norman

2011/3/3 Drew Johnson <dr...@camelini.com>:
> I made a couple of small changes to postage in order to get it working with
> the v3 server trunk. Is there value/interest in getting a postage trunk that
> is working with the v3 server trunk.
>
> - Drew
>

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org