[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1530: fix dump_string format error when CONFIG_ALLSYMS is not enabled

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #1530:
URL: https://github.com/apache/nuttx-apps/pull/1530#discussion_r1094625627


##########
system/trace/trace_dump.c:
##########
@@ -643,12 +643,21 @@ static int trace_dump_one(trace_dump_t type, FAR FILE *out, FAR uint8_t *p,
               (nst->nst_data[0] == 'B' ||
                nst->nst_data[0] == 'E'))
             {
+#ifdef CONFIG_ALLSYMS
               fprintf(out, "tracing_mark_write: %c|%d|%pS\n",
                       nst->nst_data[0], pid, (FAR void *)ip);
+#else
+              fprintf(out, "tracing_mark_write: %c|%d|%p\n",

Review Comment:
   let's fix printf to rmove S suffix instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org