You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/08/08 18:51:19 UTC
Review Request 71254: Added method to dump sorter state for debugging.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71254/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
Added method to dump sorter state for debugging.
Diffs
-----
src/master/allocator/mesos/sorter/drf/sorter.hpp 537086039fd804453ea8c682cda775d8fdff038f
src/master/allocator/mesos/sorter/drf/sorter.cpp 40397f7111d92dccecd15c9bc1ad7c45abbd850b
src/master/allocator/mesos/sorter/random/sorter.hpp f18b014ed15ff8906fbdbd3248becefde896651c
src/master/allocator/mesos/sorter/random/sorter.cpp b480aeee38f87dca852ad3c8f97bb4fe993ce068
src/master/allocator/mesos/sorter/sorter.hpp 52b8a7b57bf17759311b32aa56c26e614119b773
Diff: https://reviews.apache.org/r/71254/diff/1/
Testing
-------
make check
Dump looks like:
```
root: a b
a
b
name:
path:
kind: INTERNAL
name: a
path: a
kind: ACTIVE_LEAF
name: b
path: b
kind: ACTIVE_LEAF
```
Thanks,
Meng Zhu
Re: Review Request 71254: Added method to dump sorter state for
debugging.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71254/#review217128
-----------------------------------------------------------
Returning a JSON object seems better? We can return it from an endpoint, browsers with json extensions can easily display the tree nature of the object with syntax highlighting and expand/collapse sections, and we can manipulate it (e.g. with python) when debugging. Not to mention that's generally how we expose debugging state (e.g. files/debug endpoint).
- Benjamin Mahler
On Aug. 8, 2019, 6:51 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71254/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2019, 6:51 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added method to dump sorter state for debugging.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/sorter/drf/sorter.hpp 537086039fd804453ea8c682cda775d8fdff038f
> src/master/allocator/mesos/sorter/drf/sorter.cpp 40397f7111d92dccecd15c9bc1ad7c45abbd850b
> src/master/allocator/mesos/sorter/random/sorter.hpp f18b014ed15ff8906fbdbd3248becefde896651c
> src/master/allocator/mesos/sorter/random/sorter.cpp b480aeee38f87dca852ad3c8f97bb4fe993ce068
> src/master/allocator/mesos/sorter/sorter.hpp 52b8a7b57bf17759311b32aa56c26e614119b773
>
>
> Diff: https://reviews.apache.org/r/71254/diff/1/
>
>
> Testing
> -------
>
> make check
>
> Dump looks like:
> ```
> root: a b
> a
> b
>
> name:
> path:
> kind: INTERNAL
>
>
> name: a
> path: a
> kind: ACTIVE_LEAF
>
>
> name: b
> path: b
> kind: ACTIVE_LEAF
> ```
>
>
> Thanks,
>
> Meng Zhu
>
>