[jira] [Commented] (HIVE-27578) Refactor genJoinRelNode to use genAllRexNode instead of genAllExprNodeDesc

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-27578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752333#comment-17752333 ] 

Stamatis Zampetakis commented on HIVE-27578:
--------------------------------------------

[~soumyakanti.das] I don't understand the motivation and the impact of this change. Can you please elaborate a bit more on the description? If you can include some examples or tests that would be great as well.

> Refactor genJoinRelNode to use genAllRexNode instead of genAllExprNodeDesc
> --------------------------------------------------------------------------
>
>                 Key: HIVE-27578
>                 URL: https://issues.apache.org/jira/browse/HIVE-27578
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Soumyakanti Das
>            Assignee: Soumyakanti Das
>            Priority: Major
>              Labels: pull-request-available
>
> Currently {{genJoinRelNode}} method relies on {{genAllExprNodeDesc}} for adding backticks to the ON clause, but we can use {{genAllRexNode}} method instead, which is better because we already use RexNodes in the method and this change will make it depend on only RexNodes



--
This message was sent by Atlassian Jira
(v8.20.10#820010)