[GitHub] [lucene-solr] vonbox commented on a change in pull request #2118: SOLR-15031: Prevent null being wrapped in a QueryValueSource

[GitBox <gi...@apache.org>]

vonbox commented on a change in pull request #2118:
URL: https://github.com/apache/lucene-solr/pull/2118#discussion_r539086072



##########
File path: solr/core/src/java/org/apache/solr/search/FunctionQParser.java
##########
@@ -361,7 +361,9 @@ protected ValueSource parseValueSource(int flags) throws SyntaxError {
         ((FunctionQParser)subParser).setParseMultipleSources(true);
       }
       Query subQuery = subParser.getQuery();
-      if (subQuery instanceof FunctionQuery) {
+      if (subQuery == null) {
+        valueSource = new DoubleConstValueSource(0.0f);

Review comment:
       Having a second look I see that a ConstValueSource is a better alternative, I'll update this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org