You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/01/23 21:51:35 UTC

[jira] [Commented] (STORM-598) Newly submitted topologies do not show up on the storm ui cluser page when the Storm Cluster run out of worker slots

    [ https://issues.apache.org/jira/browse/STORM-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289951#comment-14289951 ] 

ASF GitHub Bot commented on STORM-598:
--------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/355#issuecomment-71263582
  
    The code compiles now, but I still have not been able to reproduce the original cause of this problem. am I doing something wrong?
    ```
    ./bin/storm dev-zookeeper &
    ./bin/storm nimbus &
    ./bin/storm supervisor &
    ./bin/storm ui &
    ./bin/storm logviewer &
    ```
    wait for the UI to come up
    ```
    ./bin/storm jar ./examples/storm-starter/storm-starter-topologies-0.10.0-SNAPSHOT.jar storm.starter.WordCountTopology wc -c topology.workers=4
    ./bin/storm jar ./examples/storm-starter/storm-starter-topologies-0.10.0-SNAPSHOT.jar storm.starter.WordCountTopology wc-2 -c topology.workers=4
    ```
    
    Both show up in the TopologySummary section of the index.html page.


> Newly submitted topologies do not show up on the storm ui cluser page when the Storm Cluster run out of worker slots 
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-598
>                 URL: https://issues.apache.org/jira/browse/STORM-598
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.3-rc2
>            Reporter: caofangkun
>            Assignee: caofangkun
>            Priority: Minor
>
> 1: Set up a Storm Cluster with 1 Supervisor(4 worker slots)
> 2: submit topologyA and use 4 workers 
> 3: submit topologyB with 4 workers 
> topologyB does not but should show up on the storm ui cluster page.
> See Code Line 232:
> https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/daemon/nimbus.clj#L1232
> If assignment is null, just new Assignmnet with 0 workers and 0 tasks? 
> {code:title=nimbus.clj|borderStyle=solid}
> Index: src/clj/backtype/storm/daemon/nimbus.clj
> ===================================================================
> --- src/clj/backtype/storm/daemon/nimbus.clj	(revision 4324)
> +++ src/clj/backtype/storm/daemon/nimbus.clj	(working copy)
> @@ -1230,7 +1230,9 @@
>                bases (topology-bases storm-cluster-state)
>                topology-summaries (dofor [[id base] bases :when base]
>  	                                  (let [assignment (.assignment-info storm-cluster-state id nil)
> -                                                topo-summ (TopologySummary. id
> +                                                topo-summ ( if (nil? assignment) 
> +                                                           (TopologySummary. id  (:storm-name base) 0 0 0  (time-delta (:launch-time-secs base)) (extract-status-str base))
> +                                                           (TopologySummary. id
>                                                              (:storm-name base)
>                                                              (->> (:executor->node+port assignment)
>                                                                   keys
> @@ -1244,7 +1246,7 @@
>                                                                   set
>                                                                   count)
>                                                              (time-delta (:launch-time-secs base))
> -                                                            (extract-status-str base))]
> +                                                            (extract-status-str base)))]
>                                                 (when-let [owner (:owner base)] (.set_owner topo-summ owner))
>                                                 (when-let [sched-status (.get @(:id->sched-status nimbus) id)] (.set_sched_status topo-summ sched-status))
>                                                 topo-summ
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)