[jira] [Commented] (AIRFLOW-6488) Potential error in documentation

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008987#comment-17008987 ] 

ASF GitHub Bot commented on AIRFLOW-6488:
-----------------------------------------

loicbenoit commented on pull request #7080: [AIRFLOW-6488] Add missing relation to op4
URL: https://github.com/apache/airflow/pull/7080
 
 
   See: https://airflow.apache.org/docs/stable/concepts.html#concepts-operators, near line 401
   In last "and equivalent to", it seems op4 should still depend on both op2 and op3.
   
   op1 >> op2 >> op4
   op1 >> op3 >> op4
   
   and equivalent to:
   
   op1.set_downstream([op2, op3])
   **op4.set_upstream([op2, op3])** #Expected this, but it's missing.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Potential error in documentation
> --------------------------------
>
>                 Key: AIRFLOW-6488
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6488
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: master
>         Environment: n/a
>            Reporter: Loic Benoit
>            Priority: Minor
>              Labels: documentation
>             Fix For: master
>
>
> There may be a mistake in docs/concepts.rst near line 401.
> URL: [https://airflow.apache.org/docs/stable/concepts.html#concepts-operators]
> h2. Current state:
>  
> {code:java}
> op1 >> op2 >> op4
> op1 >> op3 >> op4
> and equivalent to:
> op1.set_downstream([op2, op3])
> {code}
> h2. Problem:
> Seems to be missing the relation with op4. (This is my first day learning Airflow, so I may be wrong.)
> h2. Proposed fix:
> {code:java}
> op1 >> op2 >> op4
> op1 >> op3 >> op4
> and equivalent to:
> op1.set_downstream([op2, op3])
> op4.set_upstream([op2, op3])
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)