You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2012/04/18 23:37:14 UTC

Review Request: OOZIE-815: Remove select * from queries related to coord action

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4794/
-----------------------------------------------------------

Review request for oozie.


Summary
-------

https://issues.apache.org/jira/browse/OOZIE-815

Some changes related to rerun and log queries are pending. Please review the patch. In meanwhile, I will work on completing the patch.


This addresses bug oozie-815.
    https://issues.apache.org/jira/browse/oozie-815


Diffs
-----

  trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetByLastModifiedTimeJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForJobJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsRunningGetJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsSubsetGetForJobJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetReadyActionsJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetByLastModifiedTimeJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1327678 

Diff: https://reviews.apache.org/r/4794/diff


Testing
-------

Ran the test suite and also the cron, mapreduce example


Thanks,

Virag


Re: Review Request: OOZIE-815: Remove select * from queries related to coord action

Posted by Virag Kothari <vi...@yahoo-inc.com>.

> On 2012-04-27 20:05:47, Mona Chitnis wrote:
> > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java, line 62
> > <https://reviews.apache.org/r/4794/diff/2/?file=103222#file103222line62>
> >
> >     Should this include missing dependencies?

yes good catch, missing deps and created conf are required..thanks


> On 2012-04-27 20:05:47, Mona Chitnis wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java, line 139
> > <https://reviews.apache.org/r/4794/diff/2/?file=103224#file103224line139>
> >
> >     Why not CoordActionGetForInputCheck here?

CoordActionGetForInputCheck is used by InputCheck cmd


> On 2012-04-27 20:05:47, Mona Chitnis wrote:
> > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java, line 63
> > <https://reviews.apache.org/r/4794/diff/2/?file=103246#file103246line63>
> >
> >     What is the advantage of creating action bean objects here rather than having the query return beans itself?

query cant return the entire bean as only some of the columns are returned. query returns object[] from which bean needs to be constructed


- Virag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4794/#review7319
-----------------------------------------------------------


On 2012-04-19 18:15:29, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4794/
> -----------------------------------------------------------
> 
> (Updated 2012-04-19 18:15:29)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-815
> 
> Some changes related to rerun and log queries are pending. Please review the patch. In meanwhile, I will work on completing the patch.
> 
> 
> This addresses bug oozie-815.
>     https://issues.apache.org/jira/browse/oozie-815
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForRerunJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetByLastModifiedTimeJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForJobJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsRunningGetJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsSubsetGetForJobJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionIdsForDateRangeJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetReadyActionsJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetByLastModifiedTimeJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInfoJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForRerunJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionIdsForDatesJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1327678 
> 
> Diff: https://reviews.apache.org/r/4794/diff
> 
> 
> Testing
> -------
> 
> Ran the test suite and also the cron, mapreduce example
> 
> 
> Thanks,
> 
> Virag
> 
>


Re: Review Request: OOZIE-815: Remove select * from queries related to coord action

Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4794/#review7319
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/4794/#comment16164>

    Should this include missing dependencies?



trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
<https://reviews.apache.org/r/4794/#comment16165>

    Why not CoordActionGetForInputCheck here?



trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java
<https://reviews.apache.org/r/4794/#comment16166>

    What is the advantage of creating action bean objects here rather than having the query return beans itself?


- Mona


On 2012-04-19 18:15:29, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4794/
> -----------------------------------------------------------
> 
> (Updated 2012-04-19 18:15:29)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-815
> 
> Some changes related to rerun and log queries are pending. Please review the patch. In meanwhile, I will work on completing the patch.
> 
> 
> This addresses bug oozie-815.
>     https://issues.apache.org/jira/browse/oozie-815
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForRerunJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetByLastModifiedTimeJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForJobJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsRunningGetJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsSubsetGetForJobJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionIdsForDateRangeJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetReadyActionsJPAExecutor.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1327678 
>   trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetByLastModifiedTimeJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInfoJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForRerunJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionIdsForDatesJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1327678 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1327678 
> 
> Diff: https://reviews.apache.org/r/4794/diff
> 
> 
> Testing
> -------
> 
> Ran the test suite and also the cron, mapreduce example
> 
> 
> Thanks,
> 
> Virag
> 
>


Re: Review Request: OOZIE-815: Remove select * from queries related to coord action

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4794/#review7461
-----------------------------------------------------------

Ship it!


+1

- Mohammad


On 2012-04-27 23:22:30, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4794/
> -----------------------------------------------------------
> 
> (Updated 2012-04-27 23:22:30)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-815
> 
> Some changes related to rerun and log queries are pending. Please review the patch. In meanwhile, I will work on completing the patch.
> 
> 
> This addresses bug oozie-815.
>     https://issues.apache.org/jira/browse/oozie-815
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionIdsForDatesJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInfoJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetByLastModifiedTimeJPAExecutor.java PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1331614 
>   trunk/core/src/main/resources/oozie-default.xml 1331614 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1331614 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetReadyActionsJPAExecutor.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsJPAExecutor.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionIdsForDateRangeJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsRunningGetJPAExecutor.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsSubsetGetForJobJPAExecutor.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForJobJPAExecutor.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetByLastModifiedTimeJPAExecutor.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java 1331614 
>   trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1331614 
> 
> Diff: https://reviews.apache.org/r/4794/diff
> 
> 
> Testing
> -------
> 
> Ran the test suite and also the cron, mapreduce example
> 
> 
> Thanks,
> 
> Virag
> 
>


Re: Review Request: OOZIE-815: Remove select * from queries related to coord action

Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4794/
-----------------------------------------------------------

(Updated 2012-04-27 23:22:30.674919)


Review request for oozie.


Changes
-------

Two changes:
1) Addressing Mona's comments about coord-rerun query; reverting back to the original select * as almost all cols are required for rerun command

2) Adding support for backward compatibility for coord job/action info cmd.


Summary
-------

https://issues.apache.org/jira/browse/OOZIE-815

Some changes related to rerun and log queries are pending. Please review the patch. In meanwhile, I will work on completing the patch.


This addresses bug oozie-815.
    https://issues.apache.org/jira/browse/oozie-815


Diffs (updated)
-----

  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionIdsForDatesJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInfoJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetByLastModifiedTimeJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1331614 
  trunk/core/src/main/resources/oozie-default.xml 1331614 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1331614 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetReadyActionsJPAExecutor.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsJPAExecutor.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionIdsForDateRangeJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsRunningGetJPAExecutor.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsSubsetGetForJobJPAExecutor.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForJobJPAExecutor.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetByLastModifiedTimeJPAExecutor.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java 1331614 
  trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1331614 

Diff: https://reviews.apache.org/r/4794/diff


Testing
-------

Ran the test suite and also the cron, mapreduce example


Thanks,

Virag


Re: Review Request: OOZIE-815: Remove select * from queries related to coord action

Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4794/
-----------------------------------------------------------

(Updated 2012-04-19 18:15:29.656967)


Review request for oozie.


Changes
-------

Changes for rerun and log added


Summary
-------

https://issues.apache.org/jira/browse/OOZIE-815

Some changes related to rerun and log queries are pending. Please review the patch. In meanwhile, I will work on completing the patch.


This addresses bug oozie-815.
    https://issues.apache.org/jira/browse/oozie-815


Diffs (updated)
-----

  trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForRerunJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetByLastModifiedTimeJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForJobJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsRunningGetJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsSubsetGetForJobJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionIdsForDateRangeJPAExecutor.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetReadyActionsJPAExecutor.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1327678 
  trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetByLastModifiedTimeJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInfoJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForTimeoutJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForInputCheckJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForRerunJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForStartJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionIdsForDatesJPAExecutor.java PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1327678 
  trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1327678 

Diff: https://reviews.apache.org/r/4794/diff


Testing
-------

Ran the test suite and also the cron, mapreduce example


Thanks,

Virag