You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/05 02:59:01 UTC

[GitHub] [iceberg] JingsongLi commented on a change in pull request #1165: Make CharSequenceSet thread safe

JingsongLi commented on a change in pull request #1165:
URL: https://github.com/apache/iceberg/pull/1165#discussion_r449824804



##########
File path: api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java
##########
@@ -54,10 +54,21 @@ public boolean isEmpty() {
     return wrapperSet.isEmpty();
   }
 
+  public CharSequenceWrapper wrapper() {

Review comment:
       Maybe you can use guava `Suppliers.memoize` to help lazy-init.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org