You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by robertgmoss <gi...@git.apache.org> on 2015/01/29 22:53:20 UTC
[GitHub] incubator-brooklyn pull request: fixes JIRA issue 126
GitHub user robertgmoss opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/492
fixes JIRA issue 126
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertgmoss/incubator-brooklyn cli/fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/492.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #492
----
commit 31431684cc9daaf28bf204ecc2cb1c2d3d247378
Author: Robert Moss <ro...@gmail.com>
Date: 2015-01-29T21:50:38Z
fixes JIRA issue 126
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fixes JIRA issue 126
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/492#issuecomment-72190666
Jenkins build failure is due to errors below - can you fix those please?
[ERROR] CatalogItemSummary.java[97:1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] CatalogItemSummary.java[98:1] (whitespace) FileTabCharacter: Line contains a tab character.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fixes JIRA issue 126
Posted by robertgmoss <gi...@git.apache.org>.
Github user robertgmoss closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/492
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fixes JIRA issue 126
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/492#issuecomment-72191423
@robertgmoss Does this mean that the user is trying to connect to an old instance of brooklyn? If so then keeping `registeredType` in the constructor, but initializing `symbolicName` with it sounds like a better idea, wdyt? The point is that the server will send either one or the other, but they mean the same thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fixes JIRA issue 126
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/492#issuecomment-72201604
btw @robertgmoss only *you* have the power to close your own issues
this is a side-effect of the way apache use github; the committers can't actually close issues!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fixes JIRA issue 126
Posted by robertgmoss <gi...@git.apache.org>.
Github user robertgmoss commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/492#issuecomment-72178754
So the problem is that the json sent to the client contains this field, so
in trying to deserialize it expects this. Would it be better to use the
ignoreproperties annotation?
On 30 January 2015 at 09:13, Svetoslav <no...@github.com> wrote:
> registeredTypeName was deprecated in favor of symbolicName. Is the error
> in rest-client? Better fix it there to follow the changes in rest-server.
> If backwards compatibility is needed for existing binaries, then no need
> to create an additional constructor argument (unless required for json
> serialization) for registeredTypeName, use symbolicName to initialize the
> field.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-brooklyn/pull/492#issuecomment-72173558>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fixes JIRA issue 126
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/492#issuecomment-72173558
`registeredTypeName` was deprecated in favor of `symbolicName`. Is the error in rest-client? Better fix it there to follow the changes in rest-server.
If backwards compatibility is needed for existing binaries, then no need to create an additional constructor argument (unless required for json serialization) for `registeredTypeName`, use `symbolicName` to initialize the field.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fixes JIRA issue 126
Posted by robertgmoss <gi...@git.apache.org>.
Github user robertgmoss commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/492#issuecomment-72191410
@aledsage no need, better fix with PR/495 please close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---