[jira] [Updated] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

["Ted Yu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-20928:
---------------------------
    Summary: Rewrite calculation of midpoint in binarySearch functions to prevent overflow  (was: binarySearch function in RowIndexSeekerV1 is buggy)

> Rewrite calculation of midpoint in binarySearch functions to prevent overflow
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-20928
>                 URL: https://issues.apache.org/jira/browse/HBASE-20928
>             Project: HBase
>          Issue Type: Bug
>          Components: io
>            Reporter: saurabh singh
>            Priority: Minor
>         Attachments: HBASE-20928-fix-binarySearch-v5.patch
>
>
> There are couple of issues in the function:
>  * {{>>>}} operator would mess the values if {{low}} + {{high}} end up being negative. This shouldn't happen but I don't see anything to prevent this from happening.
>  * The code fails around boundary values of {{low}} and {{high}}. This is a well known binary search catch. [https://ai.googleblog.com/2006/06/extra-extra-read-all-about-it-nearly.html]
>  
> Most of the code should already be covered by tests. I would have liked to add a test that actually fails without the fix but given these are private methods I am not sure on the best place to add the test. Suggestions?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)